Date: Wed, 24 May 2017 14:08:24 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ed Maste <emaste@freebsd.org> Cc: Pedro Giffuni <pfg@freebsd.org>, Konstantin Belousov <kib@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi... Message-ID: <D2A5C1D1-5145-4287-BB84-B692CAF442E3@gmail.com> In-Reply-To: <CAPyFy2D0rJR27G-L8-KZLhao=3WZziXhSXdt7JhiyhaT_KsDPg@mail.gmail.com> References: <201705230929.v4N9T5g1028124@repo.freebsd.org> <c3040c70-6fc4-ac91-a887-f63bf4656a8e@FreeBSD.org> <CAPyFy2D0rJR27G-L8-KZLhao=3WZziXhSXdt7JhiyhaT_KsDPg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 24, 2017, at 09:26, Ed Maste <emaste@freebsd.org> wrote: >=20 > On 24 May 2017 at 10:53, Pedro Giffuni <pfg@freebsd.org> wrote: >>=20 >> There is now a bunch of coverity issues (OVERFLOW_BEFORE_WIDEN = mostly) >> tied to ino64_t. At least the following CIDs are related: >=20 > On a quick look the OVERFLOW_BEFORE_WIDEN issues are false positives > in practice: for correct operation the product must fit within 32 > bits, because inodes were previously 32 bits. However, it does seem > unusual to perform a multiplication with types that could overflow 32 > bits, and then store the result in a 64-bit variable. So it seems that > a code change to eliminate the warning is likely reasonable. Wouldn=E2=80=99t the proper fix be: - Check the inode value for overflow? - Cast to the smaller historical value? Or: - Widen the type for the smaller historical value to a larger value? Thanks, -Ngie PS I=E2=80=99d have to see how we fixed this internally at Isilon. We = might have a patch kicking around for this. --Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZJfZIAAoJEPWDqSZpMIYV7WsQAKz+vRLrXUUO8eWBRebNOBv6 YBhGZpNNUdWdS++LaOJONt/zKT+ShvtgDWCtosQ7U0Kx1N/ePnQfhSUrWIGSPvMK dBNpa80oScDvU24aEBaw+lOpfImKWgxkKK8Bd5QSjzorY9PPe6pde9kypr8RduCQ MPbC4a9rn4PLYqWdMJWFeWii8oonQToOo6Jlv5SdorkcpSp8KfkP1wfrgcorsS25 +ef29047NMG91Fj5PmLf9tc5znTuBap059ZAohvbVwP5BheJ4bntx36a3FDPacxf sOhshfEi+RuR1lDdOh/VP59Ek8Kt//1k0sNPemc7DnG+4OnISBm+nBUd3VIB/2cU r7q19CeU0rwBIjTygSuaE8G0vdQrTXb660l7BT5X02NK4Cgzw24NR1USmau1FkUt FXLbGEMu+wOS2nElHuaZ4PnRSuImPIpvIVbs+2lgCX6YWavPRVJn/5Jaxy+3MiHl zRqKc+PDpo1H0rIZ2qkAFd+uRdcVkp63lUP9ZGlqaDe2ikxW4VhU004Ul7sf9tVN 11nMCx1clGTh3B99R480iByuGiHS3eJmTAmxxwY9zJH61I4k1QW8n77YVIhYCwUN LQi8N3gz9GocX8VjhbfT5XiIFfFn8pX1DtNNy+GmbeBJcIv88xs7aFN9uTuwvY1K Di0zg1Cv8fpv+5q7O//y =9lgE -----END PGP SIGNATURE----- --Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2A5C1D1-5145-4287-BB84-B692CAF442E3>