Date: Fri, 04 Jan 2008 09:50:41 -0800 From: Tim Kientzle <kientzle@freebsd.org> To: Dag-Erling Smorgrav <des@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c Message-ID: <477E71F1.4080301@freebsd.org> In-Reply-To: <200801031830.m03IUb9K049549@repoman.freebsd.org> References: <200801031830.m03IUb9K049549@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav wrote: > des 2008-01-03 18:30:37 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive_read_support_format_zip.c > Added files: > lib/libarchive archive_endian.h > Log: > Crib {be,le}{16,32,64}{dec,enc} from src/sys/sys/endian.h and use it instead > of home-rolled [iu][248] in the ZIP support code. > > Approved by: kientzle > > Revision Changes Path > 1.1 +142 -0 src/lib/libarchive/archive_endian.h (new) > 1.19 +22 -57 src/lib/libarchive/archive_read_support_format_zip.c Is this really right? > +be32dec(const void *pp) > +{ > + unsigned char const *p = (unsigned char const *)pp; The "const *" is harmless enough, but dropping the leading "const" doesn't seem right at all: 'pp' is a pointer to const data, 'p' points to modifiable data. Tim Kientzle
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?477E71F1.4080301>