Date: Wed, 1 Mar 2006 11:17:27 -0800 From: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com> To: "Scott Long" <scottl@samsco.org> Cc: src-committers@freebsd.org, cokane@cokane.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Dag-Erling Sm?rgrav <des@des.no>, Ceri Davies <ceri@submonkey.net>, Eric Anderson <anderson@centtech.com> Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c Message-ID: <bb4a86c70603011117n5e942b83qf4d9ce41f6689088@mail.gmail.com> In-Reply-To: <4405E3DC.7030403@samsco.org> References: <200602252159.k1PLxT8G036312@repoman.freebsd.org> <bb4a86c70602271433g6a546df1iba2bbc9719039640@mail.gmail.com> <864q2j5voi.fsf@xps.des.no> <346a80220602282337n3a2786c1qf4f9358fa6be73d4@mail.gmail.com> <44054FB8.5010707@samsco.org> <20060301135551.GY27069@submonkey.net> <4405ACE7.6060605@centtech.com> <4405CC23.20403@samsco.org> <bb4a86c70603010925v694676faw545ddfed2668ef27@mail.gmail.com> <4405E3DC.7030403@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/1/06, Scott Long <scottl@samsco.org> wrote: > Maksim Yevmenkin wrote: > > On 3/1/06, Scott Long <scottl@samsco.org> wrote: > > > >>Eric Anderson wrote: > >> > >>>Ceri Davies wrote: > >>> > >>> > >>>>On Wed, Mar 01, 2006 at 12:39:36AM -0700, Scott Long wrote: > >>>> > >>>> > >>>> > >>>>>Coleman Kane wrote: > >>>>> > >>>>> > >>>>> > >>>>>>On 2/28/06, *Dag-Erling Sm?rgrav* <des@des.no <mailto:des@des.no>> > >>>>>>wrote: > >>>>>> > >>>>>> "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com > >>>>>> <mailto:maksim.yevmenkin@gmail.com>> writes: > >>>>>> > we should make a decision which scancodes keyboard drivers > >>>>>>should be > >>>>>> > returning and change kbdmux(4), syscons(4) etc. to support it= . > >>>>>> > > >>>>>> > until then, i'm afraid, sun rs232 and powerpc adb keyboard > >>>>>>drivers > >>>>>> > will have to translate their own scancodes into at scancodes > >>>>>>(just > >>>>>> > like ukbd(4) does). > >>>>>> > >>>>>> Considering that ukbd(4) is the only kbd driver that runs on all > >>>>>> platforms, it might make sense to have all other drivers transla= te > >>>>>> their scancodes to ukbd(4) scancodes and use that in kbdmux(4) a= nd > >>>>>> syscons(4). > >>>>>> > >>>>>> > >>>>>>I agree, especially since atkbdc's are rapidly being replaced by > >>>>>>USB on the platforms they were made for. > >>>>>> > >>>>> > >>>>>Long term, yes, but what is the risk/benefit of doing this for 6.1? > >>>>> > >>>> > >>>> > >>>>If it doesn't work, we look like bloody idiots. 6.2 isn't that far > >>>>away, I'd think that anybody could manage waiting for it a little mor= e > >>>>(especially if it goes into RELENG_6 just after the 6.1 branch). > >>>> > >>>>The above not to be taken as a comment on the change, on which I am n= ot > >>>>informed enough to hold an opinion. > >>>> > >>> > >>> > >>>Can we have it all set, built in to GENERIC, but the device hint set t= o > >>>disabled? Lots of systems, Dell PowerEdge and similar, come with a > >>>remote access card, which uses a USB tie in. The only way I've found = to > >>>make the console keyboard work after initial install, is to boot singl= e > >>>user, hack /etc/devd.conf, and reboot, which is really ugly. Many > >>>FreeBSD users get stuck with this, so it would be very nice to have a > >>>quick way to enable the kbdmux at loader time for 6.1, but if it goes = in > >>>right after, I'm not going to cry. :) > >>> > >>>Thanks again Maksim for all the work on this! > >> > >>I'd like to turn this on for the next BETA build, get feedback, then > >>decide whether or not to leave it enabled for the final 6.1 release. > >>Maksim, is that OK with you? > > > > > > yes, it should be fine. i still need to add/test hints support in > > kbdmux(4). i plan to finish it today. i will also need to MFC all my > > changes to RELENG_6. i'm not sure how much testing we want before MFC. > > should i get a blanket approval from re@? > > Instead of rushing this in, let's build BETA3 now without it and then > spend the next week getting it working at tested and polished. fine with me. more testing is always good. btw, kbdmux(4) hints support was committed to HEAD. it was actually pretty trivial to add. i briefly tested it with module and it worked for me. thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70603011117n5e942b83qf4d9ce41f6689088>