Date: Tue, 29 Mar 2016 09:42:23 +0200 From: "John Marino (FreeBSD)" <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r412019 - head/games/tbe Message-ID: <e5e99f807d75f25f74da3e4ce0e75613@secure.marino.st> In-Reply-To: <20160329073339.GA72433@FreeBSD.org> References: <201603272245.u2RMjdZS009225@repo.freebsd.org> <20160329073339.GA72433@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/29/2016 9:33 AM, Alexey Dokuchaev wrote: > On Sun, Mar 27, 2016 at 10:45:39PM +0000, John Marino wrote: >> New Revision: 412019 >> URL: https://svnweb.freebsd.org/changeset/ports/412019 >> >> Log: >> games/tbe: Fix plist (main executable wasn't listed) >> >> At some port, this port was converted from having a plist to using >> PORTDATA as an automatic generator. Unfortunately, this excluded >> the >> main executable (bin/tbe) from being packaged as well as several >> icons. >> Drop PORTDATA and bring back the full pkg-plist (it's < 300 lines). >> While here, pet portlint. >> >> Added: >> head/games/tbe/pkg-plist (contents, props changed) > > I guess pkg-plist should've been repocopied (resurrected) in this case. > I disagree. 1) It's been gone a long time and many versions have changed since. Showing changes from back then to now has no value. 2) Repocopy makes sense to me ONCE, when creating a new port. After the port is created, don't use it within a port. I don't see people doing this and I'm glad about that. If we said it's okay returning pkg-plist, then you can claim it's okay for returning patch files, which is absurd. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e5e99f807d75f25f74da3e4ce0e75613>