Date: Tue, 3 Mar 2009 17:34:10 +0000 (UTC) From: Dmitry Chagin <dchagin@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r189313 - head/sys/kern Message-ID: <200903031734.n23HYATi017058@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dchagin Date: Tue Mar 3 17:34:09 2009 New Revision: 189313 URL: http://svn.freebsd.org/changeset/base/189313 Log: as suggested by jhb@, panic in case the ncpus == 0. it helps to catch bugs in the callers. Approved by: kib (mentor) MFC after: 5 days Modified: head/sys/kern/subr_smp.c Modified: head/sys/kern/subr_smp.c ============================================================================== --- head/sys/kern/subr_smp.c Tue Mar 3 17:16:26 2009 (r189312) +++ head/sys/kern/subr_smp.c Tue Mar 3 17:34:09 2009 (r189313) @@ -366,7 +366,7 @@ smp_rendezvous_cpus(cpumask_t map, if (((1 << i) & map) != 0 && !CPU_ABSENT(i)) ncpus++; if (ncpus == 0) - return; + panic("ncpus is 0 with map=0x%x", map); /* obtain rendezvous lock */ mtx_lock_spin(&smp_ipi_mtx);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903031734.n23HYATi017058>