Date: Wed, 3 Mar 2021 08:38:05 -0700 From: Warner Losh <imp@bsdimp.com> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: Brandon Bergren <bdragon@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2. Message-ID: <CANCZdfqh%2BKtueVsmDZh-SCVQeXYc-7f28BCJYJYbUxr-cotbpQ@mail.gmail.com> In-Reply-To: <dbffbfce-feff-29a0-abce-7d89dbbced7f@freebsd.org> References: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> <14d09680-1036-4a7e-8a0e-c3063cac8bc9@www.fastmail.com> <dbffbfce-feff-29a0-abce-7d89dbbced7f@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 3, 2021 at 7:13 AM Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > > > On 3/3/21 9:05 AM, Brandon Bergren wrote: > > On Wed, Mar 3, 2021, at 6:53 AM, Rodney W. Grimes wrote: > >> What am I missing here? One place I am being told this is run in > >> an environment that may not even be an EFI booted system, and in > >> another place it is being used as a test if something is mounted > >> on it, which should only be true on an EFI booted system. > > That the script in question is a generic script that runs as part of > bsdinstall on every platform and has to be universal. > > > > The actual *problem* here is that usr.sbin/bsdinstall/scripts/bootconfig > has a default case that is > > *) die "Unsupported arch $(uname -m) for UEFI > install" > > > > which then causes the main script to bail out, leaving the system in a > half-installed state. > > > > If that had just been an exit 0 this would have never been a problem, I > suppose. > > > > Before the original change that broke this, there was a check that the > script was not running on powerpc or mips platforms before running the efi > bits, but this got taken out. > > > > Well, incidentally. The bootconfig script needs to know if there is an > ESP it should configure, but the signalling mechanism (the presence of > the ESP mount point) was being broken by mtree making that directory > unconditionally even on systems that don't use EFI. So then bootconfig > tried to set it up, but failed later on, because there was no EFI loader > to set up. The mtree change makes the ESP mount point only exist on > systems with an ESP. > So you made a unilateral change, without discussion of the bigger design, to something without even asking the original person who made the change to mtree about it for what sounds like an obscure case in the installer that could be solved in a different way? It's trivial enough to look at the boot method sysctl and skip the EFI update if we didn't boot EFI (and if by change that's not on all systems, it's easy enough to add it on all systems). I have no notion about why that wasn't considered, at least, before jumping in and taking people by surprise. Next time, talk to people first. That's the whole point of having review tools, mailing list and git blame. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqh%2BKtueVsmDZh-SCVQeXYc-7f28BCJYJYbUxr-cotbpQ>