Date: Fri, 14 May 2021 13:02:08 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255875] [PATCH] netpfil/ipfw: Fix a double free in aqm_codel_enqueue Message-ID: <bug-255875-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255875 Bug ID: 255875 Summary: [PATCH] netpfil/ipfw: Fix a double free in aqm_codel_enqueue Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: lylgood@foxmail.com Created attachment 224938 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224938&action= =3Dedit adds a new label "out" Bug File: sys/netpfil/ipfw/dn_aqm_codel.c In function aqm_codel_enqueue, it calls m_freem() to free m and goto drop. But in the drop branch, m is freed again via FREE_PKT(m) at 273, which is a double free bug. My patch adds a new label "out" and lets execution runs into the out branch after m is freed, to avoid the double free bug. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255875-227>