Date: Sun, 3 Aug 2014 09:47:58 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo <rpaulo@freebsd.org> Subject: Re: svn commit: r267937 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/json cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/... Message-ID: <9989584F-4933-4E20-B274-57CF7256272A@gmail.com> In-Reply-To: <2037442.AGE2eZkv8p@pippin.baldwin.cx> References: <201406262145.s5QLjnJH034761@svn.freebsd.org> <2037442.AGE2eZkv8p@pippin.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 28, 2014, at 9:23 PM, John Baldwin <jhb@FreeBSD.org> wrote: > On Thursday 26 June 2014 21:45:49 Rui Paulo wrote: >> Author: rpaulo >> Date: Thu Jun 26 21:45:49 2014 >> New Revision: 267937 >> URL: http://svnweb.freebsd.org/changeset/base/267937 >> >> Log: >> MFV illumos >> >> 4477 DTrace should speak JSON >> >> MFC after: 2 weeks > > This makes kernel builds depend on userland sources. This breaks a lot of my > work trees where I only checkout 'sys', and breaks a generally long-standing > feature that the kernel was self-contained (recent bmake breakage to require > the '-m /usr/src/share/mk' hack aside). Perhaps you could copy strtolctype.h > to sys/cddl/contrib/opensolaris/common/util? We already duplicate > sys/cddl/contrib/opensolaris/common/avl/avl.c in a like manner, presumably for > the same reason. Just FYI: my intention is to remove that hack requirement, at least for host != kernel version cases.. I’ve had some issues with the “fix” that wound up with a different set of hacks once the initial MAKESYSPATH is fixed. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9989584F-4933-4E20-B274-57CF7256272A>