Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 04 Sep 2014 09:51:53 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Benno Rice <benno@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r271085 - head/lib/libgeom
Message-ID:  <3000146.5OWvozVApa@ralph.baldwin.cx>
In-Reply-To: <201409040331.s843Vn5c048905@svn.freebsd.org>
References:  <201409040331.s843Vn5c048905@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, September 04, 2014 03:31:49 AM Benno Rice wrote:
> Author: benno
> Date: Thu Sep  4 03:31:48 2014
> New Revision: 271085
> URL: http://svnweb.freebsd.org/changeset/base/271085
> 
> Log:
>   Systems with lots of geom providers can end up with a kern.geom.confxml
>   value too large for the buffer allocated. Work around this by retrying
>   a few times with larger buffer sizes.

Are these systems having lots of changes to the GEOM tree while the sysctl 
handler is being invoked?  If the tree is static, the first call with an old 
of NULL should return the correct length in 'l' regardless of the size as it 
generates the entire buffer and SYSCTL_OUT's it.  (It doesn't do it piecemeal 
and fail on ENOMEM part way through the way some other broken sysctl handlers 
do.)

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3000146.5OWvozVApa>