Date: Sat, 14 Dec 2024 13:54:18 -0700 From: Warner Losh <imp@bsdimp.com> To: David Wolfskill <david@catwhisker.org> Cc: Warner Losh <imp@freebsd.org>, "Herbert J. Skuhra" <herbert@gojira.at>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 42ee30f19cc7 - main - depend-cleanup.sh: Need to delete jemalloc.3 in objtree Message-ID: <CANCZdfqAa7e1HYSkVQLrvC7Q85ZoE4mW=c-L9hNQ=e1yP5dC5A@mail.gmail.com> In-Reply-To: <Z11_F1xahbFJh4UO@albert.catwhisker.org> References: <202412132304.4BDN4QSd029112@gitrepo.freebsd.org> <87y10icwq0.wl-herbert@gojira.at> <Z11_F1xahbFJh4UO@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, Dec 14, 2024 at 5:50 AM David Wolfskill <david@catwhisker.org> wrote: > On Sat, Dec 14, 2024 at 12:47:35PM +0100, Herbert J. Skuhra wrote: > > On Sat, 14 Dec 2024 00:04:26 +0100, Warner Losh wrote: > > > > > > The branch main has been updated by imp: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=42ee30f19cc7ad85187cbf97155dbd5207a04845 > > > > > > commit 42ee30f19cc7ad85187cbf97155dbd5207a04845 > > > Author: Warner Losh <imp@FreeBSD.org> > > > AuthorDate: 2024-12-13 17:46:59 +0000 > > > Commit: Warner Losh <imp@FreeBSD.org> > > > CommitDate: 2024-12-13 23:04:34 +0000 > > > > > > depend-cleanup.sh: Need to delete jemalloc.3 in objtree > > > ... > > > Does this actually work? Should this be > > > > if [ -h "$OBJTOP"/lib/libc/jemalloc.3 ]; then > > > > ? > > Empirically: > On a system running: > FreeBSD 15.0-CURRENT #61 main-n274188-38cb1ba8637d: Fri Dec 13 11:58:34 > UTC 2024 root@freebeast.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC > amd64 1500029 1500029 > > after updating sources to main-n274215-da5aed38d80a and starting an > in-place source upgrade using meta mode, the build failed: > > ... > Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/mail/mail > Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/tftp/tftp.1.gz > make[4]: don't know how to make jemalloc.3. Stop > Yea, I tested in the wrong tree.. I've just tested in the right tree so will be pushing a fix. Warner > make[4]: stopped making "all" in /usr/src/lib/libc > .ERROR_TARGET='jemalloc.3' > .ERROR_META_FILE='' > .MAKE.LEVEL='4' > MAKEFILE='' > .MAKE.MODE='meta missing-filemon=yes missing-meta=yes silent=yes verbose' > _ERROR_CMD='.PHONY' > .... > > I then used "find" to find any ocurrences of "jemalloc.3" in > /usr/obj/; one was found: a symlink named > /usr/obj/usr/src/amd64.amd64/lib/libc/jemalloc.3, which pointed to > /usr/src/contrib/jemalloc/doc/jemalloc.3. > > The latter did not exist. > > Once I removed the symlink, the build succeeeded: > FreeBSD 15.0-CURRENT #62 main-n274215-da5aed38d80a: Sat Dec 14 12:08:41 > UTC 2024 root@freebeast.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC > amd64 1500029 1500029 > > On a pair of other (slower) machines, I then had the opportunity to > remove the symlink before starting the build; those completed without > incident. > > I believe a src/UPDATING entry would be sufficient to help folks > avoid the error condition. > > Peace, > david > -- > David H. Wolfskill david@catwhisker.org > Re. tariffs: https://en.wikipedia.org/wiki/Smoot%E2%80%93Hawley_Tariff_Act > > See https://www.catwhisker.org/~david/publickey.gpg for my public key. > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Sat, Dec 14, 2024 at 5:50 AM David Wolfskill <<a href="mailto:david@catwhisker.org">david@catwhisker.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sat, Dec 14, 2024 at 12:47:35PM +0100, Herbert J. Skuhra wrote:<br> > On Sat, 14 Dec 2024 00:04:26 +0100, Warner Losh wrote:<br> > > <br> > > The branch main has been updated by imp:<br> > > <br> > > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=42ee30f19cc7ad85187cbf97155dbd5207a04845" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=42ee30f19cc7ad85187cbf97155dbd5207a04845</a><br>; > > <br> > > commit 42ee30f19cc7ad85187cbf97155dbd5207a04845<br> > > Author: Warner Losh <imp@FreeBSD.org><br> > > AuthorDate: 2024-12-13 17:46:59 +0000<br> > > Commit: Warner Losh <imp@FreeBSD.org><br> > > CommitDate: 2024-12-13 23:04:34 +0000<br> > > <br> > > depend-cleanup.sh: Need to delete jemalloc.3 in objtree<br> > > ... <br> <br> > Does this actually work? Should this be<br> > <br> > if [ -h "$OBJTOP"/lib/libc/jemalloc.3 ]; then<br> > <br> > ?<br> <br> Empirically:<br> On a system running:<br> FreeBSD 15.0-CURRENT #61 main-n274188-38cb1ba8637d: Fri Dec 13 11:58:34 UTC 2024 <a href="mailto:root@freebeast.catwhisker.org" target="_blank">root@freebeast.catwhisker.org</a>:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1500029 1500029<br> <br> after updating sources to main-n274215-da5aed38d80a and starting an<br> in-place source upgrade using meta mode, the build failed:<br> <br> ...<br> Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/mail/mail<br> Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/tftp/tftp.1.gz<br> make[4]: don't know how to make jemalloc.3. Stop<br></blockquote><div><br></div><div>Yea, I tested in the wrong tree.. I've just tested in the right tree so will be pushing a fix.</div><div><br></div><div>Warner</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> make[4]: stopped making "all" in /usr/src/lib/libc<br> .ERROR_TARGET='jemalloc.3'<br> .ERROR_META_FILE=''<br> .MAKE.LEVEL='4'<br> MAKEFILE=''<br> .MAKE.MODE='meta missing-filemon=yes missing-meta=yes silent=yes verbose'<br> _ERROR_CMD='.PHONY'<br> ....<br> <br> I then used "find" to find any ocurrences of "jemalloc.3" in<br> /usr/obj/; one was found: a symlink named<br> /usr/obj/usr/src/amd64.amd64/lib/libc/jemalloc.3, which pointed to<br> /usr/src/contrib/jemalloc/doc/jemalloc.3.<br> <br> The latter did not exist.<br> <br> Once I removed the symlink, the build succeeeded:<br> FreeBSD 15.0-CURRENT #62 main-n274215-da5aed38d80a: Sat Dec 14 12:08:41 UTC 2024 <a href="mailto:root@freebeast.catwhisker.org" target="_blank">root@freebeast.catwhisker.org</a>:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1500029 1500029<br> <br> On a pair of other (slower) machines, I then had the opportunity to<br> remove the symlink before starting the build; those completed without<br> incident.<br> <br> I believe a src/UPDATING entry would be sufficient to help folks<br> avoid the error condition.<br> <br> Peace,<br> david<br> -- <br> David H. Wolfskill <a href="mailto:david@catwhisker.org" target="_blank">david@catwhisker.org</a><br> Re. tariffs: <a href="https://en.wikipedia.org/wiki/Smoot%E2%80%93Hawley_Tariff_Act" rel="noreferrer" target="_blank">https://en.wikipedia.org/wiki/Smoot%E2%80%93Hawley_Tariff_Act</a><br>; <br> See <a href="https://www.catwhisker.org/~david/publickey.gpg" rel="noreferrer" target="_blank">https://www.catwhisker.org/~david/publickey.gpg</a>; for my public key.<br> </blockquote></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqAa7e1HYSkVQLrvC7Q85ZoE4mW=c-L9hNQ=e1yP5dC5A>