Date: Tue, 22 Jun 2004 16:29:01 +0400 (MSD) From: Maxim Konovalov <maxim@macomnet.ru> To: Andre Oppermann <andre@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: New preview patch for ipfw to pfil_hooks conversion Message-ID: <20040622162616.O7191@mp2.macomnet.net> In-Reply-To: <40D81A53.FD490D89@freebsd.org> References: <40D754D5.1070805@freebsd.org> <20040622115532.W5744@mp2.macomnet.net> <40D81A53.FD490D89@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 22 Jun 2004, 13:38+0200, Andre Oppermann wrote: > Maxim Konovalov wrote: > > > > Hi Andre, > > > > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote: > > > > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > > > This patch significantly cleans up ip_input.c and ip_output.c. > > > > Is it possible to split that ~100KB patch in a logic chunks? One for > > phil_hook, one for ip_pcbopt, one for ip_reass etc. Much easier to > > review and commit them later. > > Of course it will be split up. I haven't done this because this is > only a preview patch of work in progress. Please HEADSUP us before commit or drop me a note, I am willing to review reass/ip options code as I spent a lot of hours parsing it. As a side note, what is "#define MAX_IPOPTLEN 40" in ip_options.h for? There is one in ip_var.h. -- Maxim Konovalov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040622162616.O7191>