Date: Sun, 10 Feb 2019 15:21:35 +0100 From: Michael Tuexen <tuexen@fh-muenster.de> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343746 - head/sys/conf Message-ID: <5445FA8B-4A76-4202-A841-A15429AA9551@fh-muenster.de> In-Reply-To: <CAG6CVpWJt%2BPGjPLFMC0Y3RhWfcUgygvPr%2BGVn2ZK-nDJ=iD=1g@mail.gmail.com> References: <201902041655.x14GtOIr046072@repo.freebsd.org> <CAG6CVpUqFp-qAYoD0CSAz%2BGZf_gcchQ0BswgxhRcYq88VO1sow@mail.gmail.com> <6436189F-037C-4AB0-A59C-BE68A781FB30@fh-muenster.de> <CAG6CVpWJt%2BPGjPLFMC0Y3RhWfcUgygvPr%2BGVn2ZK-nDJ=iD=1g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On 10. Feb 2019, at 09:38, Conrad Meyer <cem@FreeBSD.org> wrote: > > Hi Michael, > > I don't know. You can 'pkg install amd64-xtoolchain-gcc' and 'make > buildkernel KERNCONF=GENERIC CROSS_TOOLCHAIN=amd64-gcc' if you're > interested in trying it. Hi Conrad, thanks for the instructions. I tested the patch and it ends up in a system I can use. In particular the kcovtrace test program also runs. Best regards Michael > > (I'm not sure enabling coverage globally in GENERIC is appropriate > even if it did not break boot — it's usually expensive, and while > GENERIC is already slow, that doesn't mean we can just make it 10x > slower.) > > Best, > Conrad > > On Sun, Feb 10, 2019 at 12:03 AM Michael Tuexen <tuexen@fh-muenster.de> wrote: >> >>> On 10. Feb 2019, at 08:50, Conrad Meyer <cem@FreeBSD.org> wrote: >>> >>> Hi Andrew, >>> >>> This makes it compile, but instead of a build failure the kernel is >>> broken hard at runtime in early boot with GCC < 8.1. E.g., >>> amd64-xtoolchain-gcc standard cross-toolchain is still on GCC 6.4.0. >>> >>> HEAD GENERIC has been broken in one form or another for xtoolchain GCC >>> since r343713 (Feb 3), so I'm going to go ahead and turn this option >>> off in GENERIC. Feel free to reenable when you've tested that it >>> works. >> Hi Conrad, >> >> does https://reviews.freebsd.org/D19135 fix the issue you are observing? >> >> Best regards >> Michael >>> >>> Best, >>> Conrad >>> >>> On Mon, Feb 4, 2019 at 8:55 AM Andrew Turner <andrew@freebsd.org> wrote: >>>> >>>> Author: andrew >>>> Date: Mon Feb 4 16:55:24 2019 >>>> New Revision: 343746 >>>> URL: https://svnweb.freebsd.org/changeset/base/343746 >>>> >>>> Log: >>>> Only enable trace-cmp on Clang and modern GCC. >>>> >>>> It's was only added to GCC 8.1 so don't try to enable it for earlier >>>> releases. >>>> >>>> Reported by: lwhsu >>>> Sponsored by: DARPA, AFRL >>>> >>>> Modified: >>>> head/sys/conf/files >>>> head/sys/conf/kern.pre.mk >>>> >>>> Modified: head/sys/conf/files >>>> ============================================================================== >>>> --- head/sys/conf/files Mon Feb 4 16:13:41 2019 (r343745) >>>> +++ head/sys/conf/files Mon Feb 4 16:55:24 2019 (r343746) >>>> @@ -3808,7 +3808,7 @@ kern/kern_idle.c standard >>>> kern/kern_intr.c standard >>>> kern/kern_jail.c standard >>>> kern/kern_kcov.c optional kcov \ >>>> - compile-with "${NORMAL_C} -fno-sanitize-coverage=trace-pc,trace-cmp" >>>> + compile-with "${NORMAL_C} -fno-sanitize=all" >>>> kern/kern_khelp.c standard >>>> kern/kern_kthread.c standard >>>> kern/kern_ktr.c optional ktr >>>> >>>> Modified: head/sys/conf/kern.pre.mk >>>> ============================================================================== >>>> --- head/sys/conf/kern.pre.mk Mon Feb 4 16:13:41 2019 (r343745) >>>> +++ head/sys/conf/kern.pre.mk Mon Feb 4 16:55:24 2019 (r343746) >>>> @@ -120,7 +120,12 @@ SAN_CFLAGS+= -fsanitize=undefined >>>> >>>> COVERAGE_ENABLED!= grep COVERAGE opt_global.h || true ; echo >>>> .if !empty(COVERAGE_ENABLED) >>>> +.if ${COMPILER_TYPE} == "clang" || \ >>>> + (${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 80100) >>>> SAN_CFLAGS+= -fsanitize-coverage=trace-pc,trace-cmp >>>> +.else >>>> +SAN_CFLAGS+= -fsanitize-coverage=trace-pc >>>> +.endif >>>> .endif >>>> >>>> CFLAGS+= ${SAN_CFLAGS} >>>> >>> >> [-- Attachment #2 --] 0 *H 010 `He 0 *H 00PN=d0 *H 0q1 0 UDE1 0U Deutsche Telekom AG1 0 U T-TeleSec Trust Center1#0!UDeutsche Telekom Root CA 20 140722120826Z 190709235900Z0Z1 0 UDE10U DFN-Verein10U DFN-PKI1$0"UDFN-Verein PCA Global - G010"0 *H 0 g TÖP5=bnL ["t 41 R(#t^[xx(59{-E z|J Æ\+1{ $C 8jh Oxv&t kν0Ob'0 e`M #*5X'vq 5}o3]AkLQٽVVC= '0IT4qul !'>99Hjə 00U 0 U I= D{) p>d0 U #01ySz-l +30U 00bU [0Y0+!,0+!, 0+!,0 +!,0 +!, 0>U 705031/-http://pki0336.telesec.de/rl/DT_ROOT_CA_2.crl0x+l0j0,+0 http://ocsp0336.telesec.de/ocspr0:+0.http://pki0336.telesec.de/crt/DT_ROOT_CA_2.cer0 *H c (!r9FY92% }Am n,Yu3a'ò5*Iff/]n?nZ[Cc\1 _MeN2|zKM\t!uR>jӐ#nIg5MV/Ϸr>ɼ@Z=ּ÷2,jm59DXc$ Nn/8WI?nPo, FeϮٟS>/ Ƅ }{$$c4Z *y:%Be;|#),9[T00$ H30 *H 0Z1 0 UDE10U DFN-Verein10U DFN-PKI1$0"UDFN-Verein PCA Global - G010 140527145409Z 190709235900Z01 0 UDE1 0UNordrhein-Westfalen10UMuenster1 0 U Fachhochschule Muenster1#0!U Datenverarbeitungszentrale1 0UFH Muenster CA - G011 0 *H ca@fh-muenster.de0"0 *H 0 yll""AODSW{gp5ȕ[۵K{{ N '%M|( 45 ~.;. e.xH&=k| fWv293qP_vd:;IyCl|쒷 4/sCYձPG_EcjˠXh WZ xy_STbZOἥ ^_Ml3d stЎEPKp7 aa%w مgo 00U 00U 0U 00U 0 U [15B70 U #0I= D{) p>d0 U 0ca@fh-muenster.de0U 0~0=;97http://cdp1.pca.dfn.de/global-root-ca/pub/crl/cacrl.crl0=;97http://cdp2.pca.dfn.de/global-root-ca/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0G+0;http://cdp1.pca.dfn.de/global-root-ca/pub/cacert/cacert.crt0G+0;http://cdp2.pca.dfn.de/global-root-ca/pub/cacert/cacert.crt0 *H G5Jo5-km˅qtM h(gsQb@2^Cl}h^tB f!*$(Y1Kdlh`V_+ tpz-ӎ~0kY!@Fw7+`vezZ%H&@ E Ɏ, lfQ@k}u#>wڹf5Zl$K@eukYqFI;6]7.܋@Zy aƄ}~~0 0t70 *H 01 0 UDE1 0UNordrhein-Westfalen10UMuenster1 0 U Fachhochschule Muenster1#0!U Datenverarbeitungszentrale1 0UFH Muenster CA - G011 0 *H ca@fh-muenster.de0 160704070613Z 190704070613Z0|1 0 UDE1 0 U Fachhochschule Muenster1200U )Fachbereich Elektrotechnik und Informatik10U Michael Tuexen0"0 *H 0 ̚Pmٛn6 lW <ƣ ~Kyw'L797V8 yWY3H?.M:u.ۈdU=w>@.vWb_uK?XXxS6.N SY|n1kX_+\2L-=p ,&e;:ה⒬ b G-_W ԵDg bS" w`CD k [}m\! G0C0@U 9070+!,0+!,0 +!,0 U 0 0U 0 U %0++0 U jf fEu0 U #0 [15B70 U 0tuexen@fh-muenster.de0U 0~0=;97http://cdp1.pca.dfn.de/fh-muenster-ca/pub/crl/cacrl.crl0=;97http://cdp2.pca.dfn.de/fh-muenster-ca/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0G+0;http://cdp1.pca.dfn.de/fh-muenster-ca/pub/cacert/cacert.crt0G+0;http://cdp2.pca.dfn.de/fh-muenster-ca/pub/cacert/cacert.crt0 *H Hx:Ti ʆ,$c`)nqF?ŖNqeu7B> -,!ŃRK~SyFrIʲ}iI81|W'·~'m >bZ5he ߲QN*t 4vKsnsQqϨIG ^VTU/<[U9J .B1i67(ɐvH )1905001 0 UDE1 0UNordrhein-Westfalen10UMuenster1 0 U Fachhochschule Muenster1#0!U Datenverarbeitungszentrale1 0UFH Muenster CA - G011 0 *H ca@fh-muenster.det70 `He 70 *H 1 *H 0 *H 1 190210142136Z0/ *H 1" :tt˜ O⮨]KG4dF:z=0 +71001 0 UDE1 0UNordrhein-Westfalen10UMuenster1 0 U Fachhochschule Muenster1#0!U Datenverarbeitungszentrale1 0UFH Muenster CA - G011 0 *H ca@fh-muenster.det70 *H 1ՠ01 0 UDE1 0UNordrhein-Westfalen10UMuenster1 0 U Fachhochschule Muenster1#0!U Datenverarbeitungszentrale1 0UFH Muenster CA - G011 0 *H ca@fh-muenster.det70 *H nDl;[C (o S[ sԵKEl()HwBN$4( h Y閑!aq @L R]kb?f Y Nv/]Ki!蘑Xr{a(AuReUlvԁIiD0ZҮۻcP%nٓѶDƆX Sol0_ak "2|Bˢy>: f
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5445FA8B-4A76-4202-A841-A15429AA9551>