Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 May 2017 21:58:48 -0700
From:      Mark Millard <markmi@dsl-only.net>
To:        mav@FreeBSD.org
Cc:        svn-src-head@freebsd.org, freebsd-arm <freebsd-arm@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: svn commit: r317659 - head/sys/dev/uart [head -r317729 for armv6/7: ns8250_drain : error: implicit declaration of function 'ns8250_drain' is invalid in C99]
Message-ID:  <8F563A38-A8E1-4008-9BFA-D71103E9223F@dsl-only.net>
In-Reply-To: <C2EC2C79-A6BD-46A4-B140-60E88C46118C@dsl-only.net>
References:  <C2EC2C79-A6BD-46A4-B140-60E88C46118C@dsl-only.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2017-May-3, at 4:47 AM, Mark Millard <markmi@dsl-only.net> wrote:

>> Author: mav
>> Date: Mon May  1 19:47:10 2017
>> New Revision: 317659
>> URL:=20
>> https://svnweb.freebsd.org/changeset/base/317659
>>=20
>>=20
>> Log:
>>  Make some UART consoles to not spin wait for data to be sent.
>>=20
>>  At least with Tx FIFO enabled it shows me ~10% reduction of verbose =
boot
>>  time with serial console at 115200 baud.
>>=20
>>  Reviewed by:	marcel
>>  MFC after:	2 weeks
>>=20
>> Modified:
>>  head/sys/dev/uart/uart_dev_lpc.c
>>  head/sys/dev/uart/uart_dev_ns8250.c
>=20
>=20
> After building head -r317729 for amd64 and aarch64,
> when I tried armv6 I instead got the following failure:
>=20
> --- uart_dev_lpc.o ---
> /usr/src/sys/dev/uart/uart_dev_lpc.c:892:4: error: implicit =
declaration of function 'ns8250_drain' is invalid in C99 =
[-Werror,-Wimplicit-function-declaration]
>                        ns8250_drain(bas, UART_DRAIN_TRANSMITTER);
>                        ^
> /usr/src/sys/dev/uart/uart_dev_lpc.c:892:4: note: did you mean =
'lpc_ns8250_drain'?
> /usr/src/sys/dev/uart/uart_dev_lpc.c:140:1: note: 'lpc_ns8250_drain' =
declared here
> lpc_ns8250_drain(struct uart_bas *bas, int what)
> ^
> /usr/src/sys/dev/uart/uart_dev_lpc.c:892:4: error: this function =
declaration is not a prototype [-Werror,-Wstrict-prototypes]
>                        ns8250_drain(bas, UART_DRAIN_TRANSMITTER);
>                        ^
> 2 errors generated.

head -r317752 appears to have fixed this: a rebuild
based on -r317784 completed for armv6.

Thanks.

=3D=3D=3D
Mark Millard
markmi at dsl-only.net




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8F563A38-A8E1-4008-9BFA-D71103E9223F>