Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Feb 2009 09:04:51 -0800
From:      Sean Bruno <sean.bruno@dsl-only.net>
To:        Ganbold <ganbold@micom.mng.net>
Cc:        scottl@freebsd.org, freebsd-firewire@FreeBSD.org
Subject:   Re: Final patch for -current
Message-ID:  <1234458291.30696.186.camel@localhost.localdomain>
In-Reply-To: <4994320B.4060900@micom.mng.net>
References:  <1234414082.30696.185.camel@localhost.localdomain> <4994320B.4060900@micom.mng.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2009-02-12 at 22:28 +0800, Ganbold wrote:
> Sean,
> 
> How about following redundant loop near the end of fwohci.c?
> 
> --- sys/dev/firewire/fwohci.c	2008-11-22 14:39:45.000000000 +0800
> +++ /var/current/mysrc/sys/dev/firewire/fwohci.c	2008-11-25 11:36:09.000000000 +0800
> @@ -2973,7 +2973,7 @@
>  		db_tr = STAILQ_NEXT(db_tr, link);
>  		resCount = FWOHCI_DMA_READ(db_tr->db[0].db.desc.res)
>  						& OHCI_COUNT_MASK;
> -	} while (resCount == 0)
> +	}
>  	printf(" done\n");
>  	dbch->top = db_tr;
>  	dbch->buf_offset = dbch->xferq.psize - resCount;
> 
> thanks,
> 
> Ganbold

Yep.  That should die.  Let me test it.

Sean




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1234458291.30696.186.camel>