Date: Fri, 7 Apr 2017 01:03:49 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Eric Badger <badger@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r315949 - in stable: 10/sys/kern 10/sys/sys 10/tests/sys/kern 11/sys/kern 11/sys/sys 11/tests/sys/kern Message-ID: <41CB382E-997A-4A2D-9E85-2BDE7450BB29@gmail.com> In-Reply-To: <201703251333.v2PDXOmS004369@repo.freebsd.org> References: <201703251333.v2PDXOmS004369@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_5DB7A95E-5C58-480A-85D4-EDFA19EC69AD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 25, 2017, at 06:33, Eric Badger <badger@FreeBSD.org> wrote: >=20 > Author: badger > Date: Sat Mar 25 13:33:23 2017 > New Revision: 315949 > URL: https://svnweb.freebsd.org/changeset/base/315949 >=20 > Log: > MFC r313992, r314075, r314118, r315484: >=20 > r315484: > ptrace_test: eliminate assumption about thread scheduling >=20 > A couple of the ptrace tests make assumptions about which thread = in a > multithreaded process will run after a halt. This makes the tests = less > portable across branches, and susceptible to future breakage. = Instead, > twiddle thread scheduling and priorities to match the tests' > expectation. >=20 > r314118: > Actually fix buildworlds other than i386/amd64/sparc64 after = r313992 >=20 > Disable offending test for platforms without a userspace visible > breakpoint(). >=20 > r314075: > Fix world build for archs where __builtin_debugtrap() does not = work. >=20 > The offending code was introduced in r313992. >=20 > r313992: > Defer ptracestop() signals that cannot be delivered immediately >=20 > When a thread is stopped in ptracestop(), the ptrace(2) user may = request > a signal be delivered upon resumption of the thread. Heretofore, = those signals > were discarded unless ptracestop()'s caller was issignal(). Fix = this by > modifying ptracestop() to queue up signals requested by the = ptrace user that > will be delivered when possible. Take special care when the = signal is SIGKILL > (usually generated from a PT_KILL request); no new stop events = should be > triggered after a PT_KILL. >=20 > Add a number of tests for the new functionality. Several tests = were authored > by jhb. I think this change broke ptrace_test: = https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-test/968/testReport/jun= it/sys.kern/ptrace_test/ptrace__PT_KILL_competing_stop/ . Cheers, -Ngie --Apple-Mail=_5DB7A95E-5C58-480A-85D4-EDFA19EC69AD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY50fmAAoJEPWDqSZpMIYVEP4P/R+Z5hEpYPL7o0yZFoHmtPBL tYC0psv9s/dkTE74aHrwZRqfv0aZRlve4Aq1eNnmQViP5eEDg+YF5gjiRQUyM48o hn9xH2d+eWZyYOzpmw/jEgn2rFxdKhFXD3eUPUtx0AQEdX86AVm7zsjsPqzRJmti WhPXSgXdolRCNV+F3xbhIEBvO6IBx0q9NHTnri7GAQx4JxWnSP7P1Z1SMgBCTccI HT+gvHLal/cILjgY8PgZK23/AgggDj9VRbAeckehRyFA0WvQlF08eJbVOtbdDNTX +rSxZgYFWTx+0e/kiBHKjUBFf7QevdI3cFCvOcwsqsUYH75+gEf6FsFfWQyLDUaz 98gY7H5/rl8Xjkp8TZNNiedw///23ERSJ/7Le/DOzK799LGdpGRPsY7LNd4mBINI eOKJVgS0AjBphhidCbRMSeh6r0F3NG4M4+yGnfNljn8VRMByMYaaqSaXdMq3ByxI 8MYMHfeaAs5elfisktA5yS/Gvk6DzY2H22+1+oKb7pOHdZTR5KJlQ/rBaz4yyRMU KhxSnx7FnFDL5gWpiE+HNv5rSdsfCUmvIZetVBhvWijuJ5ZiU6ZrUa5sVfR3fMlo hZ7ylwMgef1AHzjPVCvdn1XFwk1KPG4O6h3iscij4dPsVdqSAzrEXrk17LulvbFt UUfyQ4afYqSJeFkMcPPz =YSRK -----END PGP SIGNATURE----- --Apple-Mail=_5DB7A95E-5C58-480A-85D4-EDFA19EC69AD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41CB382E-997A-4A2D-9E85-2BDE7450BB29>