Date: Sat, 21 Aug 1999 01:53:20 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_physio.c Message-ID: <19990821015320.A58052@dragon.nuxi.com> In-Reply-To: <Pine.BSF.4.10.9908210117300.56889-100000@freefall.freebsd.org>; from Brian F. Feldman on Sat, Aug 21, 1999 at 01:18:42AM -0700 References: <11805.935223305@critter.freebsd.dk> <Pine.BSF.4.10.9908210117300.56889-100000@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > Next we assign blockno to bp->b_blockno which is 32 bits wide, > > what happens to the upper 32 bits ? They're ignored, so the > > value of bp->b_blockno will be: 0x00000000. > > Ah, so you're checking for an overflow. Now it's clear to me, thanks :) IMHO we really should add a line comment. Someone looking at that piece of code will really wonder why you are doing the check. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990821015320.A58052>