Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Jan 2017 09:45:49 +0100
From:      =?utf-8?Q?Edward_Tomasz_Napiera=C5=82a?= <trasz@FreeBSD.org>
To:        Ryan Stone <rysto32@gmail.com>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r311283 - head/sys/cam/ctl
Message-ID:  <7A6F3E33-8994-4DC2-9B2A-5C23E379680E@FreeBSD.org>
In-Reply-To: <CAFMmRNwWD9Z8hHA9yJiJsFWHP6LexP3kdut5EE5qTPLDArdyhA@mail.gmail.com>
References:  <201701041250.v04Coits085210@repo.freebsd.org> <CAFMmRNwWD9Z8hHA9yJiJsFWHP6LexP3kdut5EE5qTPLDArdyhA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Dnia 04.01.2017 o godz. 16:38 Ryan Stone <rysto32@gmail.com> napisa=C5=82(a)=
:

>> On Wed, Jan 4, 2017 at 7:50 AM, Edward Tomasz Napierala <trasz@freebsd.or=
g> wrote:
>> +       refcount_release(&cs->cs_outstanding_ctl_pdus);
>=20
> Shouldn't the return value of refcount_release() be checked?

Not in this case.  The destruction of  cfumass sessions is always done in on=
e specific place; everywhere else we don't care whether the reference was th=
e last one or not.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7A6F3E33-8994-4DC2-9B2A-5C23E379680E>