Date: Wed, 20 Jun 2007 00:40:08 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Coleman Kane <cokane@FreeBSD.org>, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c Message-ID: <1182292808.38663.23.camel@ikaros.oook.cz> In-Reply-To: <46782564.70700@root.org> References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <1182268273.23264.3.camel@erwin.int.cokane.org> <1182268443.21730.75.camel@pav.hide.vol.cz> <1182276521.23264.6.camel@erwin.int.cokane.org> <20070619184124.GA96145@rot13.obsecurity.org> <46782564.70700@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-P6eLu9KJHkNlyF427foR
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Nate Lawson p=ED=B9e v =FAt 19. 06. 2007 v 11:50 -0700:
> Kris Kennaway wrote:
> > On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote:
> >> On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote:
> >>> Coleman Kane p????e v ??t 19. 06. 2007 v 11:51 -0400:
> >>>> On Mon, 2007-06-18 at 22:49 +0000, Pav Lucistnik wrote:
> >>>>> pav 2007-06-18 22:49:13 UTC
> >>>>>
> >>>>> FreeBSD src repository (doc,ports committer)
> >>>>>
> >>>>> Modified files:
> >>>>> usr.sbin/pkg_install/lib deps.c=20
> >>>>> Log:
> >>>>> - Replace rather inefficient bubble sort with a recursive depth-f=
irst search.
> >>>>> This speeds up registration of packages considerably.
> >>>>> - style(9) police welcome!
> >>>>> =20
> >>>>> PR: bin/112630
> >>>>> Submitted by: Stephen Montgomery-Smith <stephen@cauchy.math.mis=
souri.edu>
> >>>>> Tested by: bento i386 experimental run
> >>>>> MFC after: 14 days
> >>>>> =20
> >>>>> Revision Changes Path
> >>>>> 1.12 +111 -65 src/usr.sbin/pkg_install/lib/deps.c
> >>>>>
> >>>> Is this by any chance connected to why many of my gnome2 dependencie=
s
> >>>> would take longer to register than to compile?
> >>> Are you observing slowdown registering ports with this patch?
> >>>
> >> I don't think so. I don't even know if I have the latest sources for
> >> pkg_install down yet.
> >>
> >> I was actually referring to my experience since the x.org modularizati=
on
> >> that ended up (I think) causing so many dependencies on some packages
> >> that registration was awfully slow. I wanted to know if this patch was
> >> expected to fix that problem.
> >=20
> > Yes, precisely so.
>=20
> Excellent! Thanks for working on this, Pav.
All fame goes to the submitter, who wrote it, and to Kris, who managed
the experimental run.
I'm just a scrape goat for purposes of src repo committing :)
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
The number you dialed is imaginary.
Please turn your phone by 90 degrees and try again.
--=-P6eLu9KJHkNlyF427foR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD4DBQBGeFtEntdYP8FOsoIRAtjjAJdO+VUboIv3CpfLcrJm9aCeJSATAJ9KEcIC
Xv4Xn4bTeCGU2bbf8+cMMQ==
=DT4n
-----END PGP SIGNATURE-----
--=-P6eLu9KJHkNlyF427foR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1182292808.38663.23.camel>