Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Mar 2010 19:23:00 -0700
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        Peter Pentchev <roam@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/dns/c-ares Makefile distinfo pkg-plist  ports/dns/c-ares/files ares-config-info.patch patch-Makefile.in
Message-ID:  <20100326192300.25171ab9.stas@FreeBSD.org>
In-Reply-To: <201003221056.o2MAu4D5001930@repoman.freebsd.org>
References:  <201003221056.o2MAu4D5001930@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Mon, 22 Mar 2010 10:56:04 +0000 (UTC)
Peter Pentchev <roam@FreeBSD.org> mentioned:

> roam        2010-03-22 10:56:04 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     dns/c-ares           Makefile distinfo pkg-plist 
>     dns/c-ares/files     ares-config-info.patch patch-Makefile.in 
>   Log:
>   Update to c-ares-1.7.0.  In the process:
>   - actually pass the options-enabled arguments to the configure script!
>   - add the "hide symbols" configurable knob, though I've no idea why
>     anybody would want to turn that off... except maybe for debugging
>   - install the "acountry", "adig", and "ahost" programs, since they do
>     come in useful every now and then
>   - refresh the patches and add descriptions at the top
>   
>   Revision  Changes    Path
>   1.12      +16 -3     ports/dns/c-ares/Makefile
> http://cvsweb.FreeBSD.org/ports/dns/c-ares/Makefile.diff?r1=1.11&r2=1.12
> | --- ports/dns/c-ares/Makefile	2009/06/23 13:27:53	1.11
> | +++ ports/dns/c-ares/Makefile	2010/03/22 10:56:04	1.12
> | @@ -2,11 +2,11 @@
> |  # Date created:		8 September 2003
> |  # Whom:			roam@FreeBSD.org
> |  #
> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/dns/c-ares/Makefile,v 1.11 2009/06/23 13:27:53 pav Exp $
> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/dns/c-ares/Makefile,v 1.12 2010/03/22 10:56:04 roam Exp $
> |  #
> |  
> |  PORTNAME=	c-ares
> | -PORTVERSION=	1.6.0
> | +PORTVERSION=	1.7.0
> |  CATEGORIES=	dns
> |  MASTER_SITES=	http://c-ares.haxx.se/
> |  
> | @@ -15,6 +15,7 @@ COMMENT=	An asynchronous DNS resolver li
> |  
> |  OPTIONS=	CONFIG_INFO	"Add the ares_config_info patch" ON \
> |  		DEBUG		"Build with debug information" OFF \
> | +		HIDE_SYMBOLS	"Hide internal library symbols" ON \
> |  		OPTIMIZED_CFLAGS	"Build with compiler optimizations" OFF
> |  
> |  CONFLICTS=	ares-1.*
> | @@ -32,6 +33,11 @@ CONFIGURE_ARGS+=	--enable-debug
> |  .else
> |  CONFIGURE_ARGS+=	--disable-debug
> |  .endif
> | +.if defined(WITH_HIDE_SYMBOLS)
> | +CONFIGURE_ARGS+=	--enable-symbol-hiding
> | +.else
> | +CONFIGURE_ARGS+=	--disable-symbol-hiding
> | +.endif

You have HIDE_SYMBOLS "on" by default, so the check should look like
.if !defined(WITHOUT_HIDE_SYMBOLS)

Otherwise the behaviour of the port is inconsistent wrt. to the batch builds.
Now the package built from the port include library symbols which is not default.

-- 
Stanislav Sedov
ST4096-RIPE

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJLrWwEAAoJEL8lojEJL9nwUXMQALuv4rZh6miS7/pI+b7DdlcK
LLOlqV5lUXGBuetSg3uaxz0xUZsXPJx+g8X3WpMURgHD1x9YMCdTP2qL1ZJtmcF1
QaFo3/l2kfQ63toQbrNUB4Tn2ZkR8D+QwnLDELBQv4xDDoP0UKysCsgxW/40LpCF
exEMeJYAATqiaHoboxqz3fKHudO3G1FoJEblDnpUW31ODeD/GPDKxeY5TaffFRF1
yXn/Blq+kPHE2CjqlqqgimxSjWmsCvOf8GLtkPQQBA6N3uv4BIgAvQlUkyAE87GO
M73N6PPWTv3b91+0QJGMqtjHdiBK41q+71P9KELAbB4qr3xqWbxm2iHb3YrYYW03
GOzXLeZM2vGsKcNSwvU4dIgYf322Vufir8AQ6HbHedx4bJ+mVY3cMhqdHLw7Swew
j28XJO6Fb8mBd0x8THOYprhmN07Jhi544/lwEyR8PJSJXcydIEcp0lJpZJBVzNu4
9FCcQIuRRT7Ae0kvguZVT6ihYhSxuKBs/ODIupcNm20OHaVqPD5sVGb7CSmLbn7E
tLNlY+bq+B9Qay9Xc1oI9pGwMGCrpVXkUAdyck1hfGY58vwWcTfWUJMElcxj7emz
AIw4fWIKs2L052putu9n6TmIJ6xpF+5qAu94cTPdp2vtcDg0xy5bKGxaSIiOPoGv
Z4Dp0j83CjO+2hG1H0u2
=DGDQ
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100326192300.25171ab9.stas>