Date: Mon, 19 May 2003 14:53:40 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/avr-libc Makefile Message-ID: <20030519115339.GI17366@sunbay.com> In-Reply-To: <20030519114332.GG17366@sunbay.com> References: <200305190828.h4J8S8l0069634@repoman.freebsd.org> <20030519094115.GC1035@sunbay.com> <20030519115435.C2937@uriah.heep.sax.de> <20030519104604.GB17366@sunbay.com> <20030519125334.D2937@uriah.heep.sax.de> <20030519114332.GG17366@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
And a quick fix for the port being:
%%%
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/avr-libc/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile 19 May 2003 11:37:08 -0000 1.21
+++ Makefile 19 May 2003 11:50:36 -0000
@@ -33,6 +33,9 @@
CONFIGURE_ARGS= --enable-doc --disable-versioned-doc
# Work around the braind*** introduced by <bsd.cpu.mk> in freebsd-current.
MAKE_ENV= NO_CPU_CFLAGS=true
+# Prevent bsd.port.mk from setting CFLAGS/CXXFLAGS to unfriendly values.
+CFLAGS= -O -pipe
+CXXFLAGS= -O -pipe
do-build:
(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ./domake MAKE=${GMAKE})
%%%
Note: this is only tested with "make -n do-build".
On Mon, May 19, 2003 at 02:43:32PM +0300, Ruslan Ermilov wrote:
> On Mon, May 19, 2003 at 12:53:34PM +0200, Joerg Wunsch wrote:
> > As Ruslan Ermilov wrote:
> >
> > > Hm, so what's broken then? If NO_CPU_CFLAGS is set, the effect
> > > of bsd.cpu.mk is null, if I'm reading the code correctly. Can
> > > you please show me the actual error, as I can't find it anywhere
> > > on bento.
> >
> > /var/portbuild/i386/archive/errorlogs/e.5.2003051313/avr-libc-2003.05.11.log
> >
> OK, I found the root of the problem. It's not the port that is broken,
> nor bsd.cpu.mk (if you set NO_CPU_CFLAGS, it gives you what you have
> asked it about), but rather a bsd.port.mk that is broken, by setting
> CFLAGS to what they are. I've edited the output slighly with fmt(1)
> to make it fit the 80-column screen, and underlined the offending
> lines:
>
> allmouth# make -n do-build | fmt
> (cd /CURRENT/usr/ports/devel/avr-libc/work/avr-libc-2003.05.11;
> /usr/bin/env NO_CPU_CFLAGS=true SHELL=/bin/sh PORTOBJFORMAT=elf
> ^^^^^^^^^^^^^^^^^^ it's okay
> PREFIX=/usr/local LOCALBASE=/usr/local X11BASE=/usr/X11R6
> MOTIFLIB="-L/usr/X11R6/lib -lXm -lXp" LIBDIR="/usr/lib" CFLAGS="-O
> -pipe -march=pentiumpro" CXXFLAGS=" -O -pipe -march=pentiumpro"
> ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
> MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install -c -s -o root
> -g wheel -m 555" BSD_INSTALL_SCRIPT="install -c -o root -g wheel
> -m 555" BSD_INSTALL_DATA="install -c -o root -g wheel -m 444"
> BSD_INSTALL_MAN="install -c -o root -g wheel -m 444" ./domake
> MAKE=gmake)
>
> Running it like this is okay:
>
> allmouth# make __MAKE_CONF=/dev/null -n do-build | fmt
> (cd /CURRENT/usr/ports/devel/avr-libc/work/avr-libc-2003.05.11;
> /usr/bin/env NO_CPU_CFLAGS=true SHELL=/bin/sh PORTOBJFORMAT=elf
> PREFIX=/usr/local LOCALBASE=/usr/local X11BASE=/usr/X11R6
> MOTIFLIB="-L/usr/X11R6/lib -lXm -lXp" LIBDIR="/usr/lib" CFLAGS="-O
> -pipe " CXXFLAGS=" -O -pipe " MANPREFIX="/usr/local"
> BSD_INSTALL_PROGRAM="install -c -s -o root -g wheel -m 555"
> BSD_INSTALL_SCRIPT="install -c -o root -g wheel -m 555"
> BSD_INSTALL_DATA="install -c -o root -g wheel -m 444"
> BSD_INSTALL_MAN="install -c -o root -g wheel -m 444" ./domake
> MAKE=gmake)
>
>
>
> Cheers,
> --
> Ruslan Ermilov Sysadmin and DBA,
> ru@sunbay.com Sunbay Software AG,
> ru@FreeBSD.org FreeBSD committer,
> +380.652.512.251 Simferopol, Ukraine
>
> http://www.FreeBSD.org The Power To Serve
> http://www.oracle.com Enabling The Information Age
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+yMXDUkv4P6juNwoRAlyhAJ0dP7v2B3J5ou704gWOcAZ0Fv9g7gCfcTs2
pryBuMYVgD9jLmBRzG+u46I=
=pgNO
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030519115339.GI17366>