Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 10 Sep 2009 11:27:07 +0000 (UTC)
From:      Attilio Rao <attilio@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r197058 - stable/8/contrib/gdtoa
Message-ID:  <200909101127.n8ABR76M018057@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: attilio
Date: Thu Sep 10 11:27:07 2009
New Revision: 197058
URL: http://svn.freebsd.org/changeset/base/197058

Log:
  MFC r196916:
  Fix a list overrun.
  
  Sponsored by:	Sandvine Incorporated
  Approved by:	re (kib)

Modified:
  stable/8/contrib/gdtoa/gdtoaimp.h
  stable/8/contrib/gdtoa/misc.c

Modified: stable/8/contrib/gdtoa/gdtoaimp.h
==============================================================================
--- stable/8/contrib/gdtoa/gdtoaimp.h	Thu Sep 10 08:33:28 2009	(r197057)
+++ stable/8/contrib/gdtoa/gdtoaimp.h	Thu Sep 10 11:27:07 2009	(r197058)
@@ -485,7 +485,7 @@ extern pthread_mutex_t __gdtoa_locks[2];
 		_pthread_mutex_unlock(&__gdtoa_locks[n]);	\
 } while(0)
 
-#define Kmax 15
+#define Kmax 9
 
  struct
 Bigint {

Modified: stable/8/contrib/gdtoa/misc.c
==============================================================================
--- stable/8/contrib/gdtoa/misc.c	Thu Sep 10 08:33:28 2009	(r197057)
+++ stable/8/contrib/gdtoa/misc.c	Thu Sep 10 11:27:07 2009	(r197058)
@@ -55,7 +55,9 @@ Balloc
 #endif
 
 	ACQUIRE_DTOA_LOCK(0);
-	if ( (rv = freelist[k]) !=0) {
+	/* The k > Kmax case does not need ACQUIRE_DTOA_LOCK(0), */
+	/* but this case seems very unlikely. */
+	if (k <= Kmax && (rv = freelist[k]) !=0) {
 		freelist[k] = rv->next;
 		}
 	else {
@@ -65,7 +67,7 @@ Balloc
 #else
 		len = (sizeof(Bigint) + (x-1)*sizeof(ULong) + sizeof(double) - 1)
 			/sizeof(double);
-		if (pmem_next - private_mem + len <= PRIVATE_mem) {
+		if (k <= Kmax && pmem_next - private_mem + len <= PRIVATE_mem) {
 			rv = (Bigint*)pmem_next;
 			pmem_next += len;
 			}
@@ -89,10 +91,14 @@ Bfree
 #endif
 {
 	if (v) {
-		ACQUIRE_DTOA_LOCK(0);
-		v->next = freelist[v->k];
-		freelist[v->k] = v;
-		FREE_DTOA_LOCK(0);
+		if (v->k > Kmax)
+			free((void*)v);
+		else {
+			ACQUIRE_DTOA_LOCK(0);
+			v->next = freelist[v->k];
+			freelist[v->k] = v;
+			FREE_DTOA_LOCK(0);
+			}
 		}
 	}

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909101127.n8ABR76M018057>