Date: Sun, 30 Nov 2025 14:56:01 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Matthias Fechner <mfechner@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4030b7d57c68 - main - devel/opentelemetry-cpp: fix build error Message-ID: <CAMHz58Q1MWCCfgogRatQsq=RGwP2sAPyezom%2BHq3kU_XwU0SeA@mail.gmail.com> In-Reply-To: <692bdb7d.ae5f.1aeefd9f@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Nov 30, 2025 at 1:52 PM Matthias Fechner <mfechner@freebsd.org> wrote: > The branch main has been updated by mfechner: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=4030b7d57c68fda7bad3230379790065dbb1ed39 > > commit 4030b7d57c68fda7bad3230379790065dbb1ed39 > Author: Matthias Fechner <mfechner@FreeBSD.org> > AuthorDate: 2025-11-30 05:50:26 +0000 > Commit: Matthias Fechner <mfechner@FreeBSD.org> > CommitDate: 2025-11-30 05:50:26 +0000 > > devel/opentelemetry-cpp: fix build error > > Added devel/c4core as a lib dependency: > ====> Running Q/A tests (stage-qa) > Error: /usr/local/lib/libopentelemetry_configuration.so.1.24.0 is > linked to /usr/local/lib/libc4core.so.0.2.6 from devel/c4core but it is not > declared as a dependency > Warning: you need LIB_DEPENDS+=libc4core.so:devel/c4core > Warning: you might not need LIB_DEPENDS on libcurl.so > Warning: you might not need LIB_DEPENDS on libgtest.so > *** Error code 1 > > Approved by: just-fix-it > This is incorrect. It is an indirect dependency brought by devel/rapidyaml. Since it is not a direct dependency, it should not be added to LIB_DEPENDS. > --- > devel/opentelemetry-cpp/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/devel/opentelemetry-cpp/Makefile > b/devel/opentelemetry-cpp/Makefile > index 65622b0ee5b9..7b5c7e99f3a1 100644 > --- a/devel/opentelemetry-cpp/Makefile > +++ b/devel/opentelemetry-cpp/Makefile > @@ -1,6 +1,7 @@ > PORTNAME= opentelemetry-cpp > PORTVERSION= 1.24.0 > DISTVERSIONPREFIX= v > +PORTREVISION= 1 > CATEGORIES= devel > > MAINTAINER= sunpoet@FreeBSD.org > @@ -11,7 +12,8 @@ WWW= https://opentelemetry.io/ \ > LICENSE= APACHE20 > LICENSE_FILE= ${WRKSRC}/LICENSE > > -LIB_DEPENDS= libcurl.so:ftp/curl \ > +LIB_DEPENDS= libc4core.so:devel/c4core \ > + libcurl.so:ftp/curl \ > libgtest.so:devel/googletest \ > libryml.so:devel/rapidyaml > TEST_DEPENDS= benchmark>=0:devel/benchmark > > [-- Attachment #2 --] <div dir="ltr"><div>On Sun, Nov 30, 2025 at 1:52 PM Matthias Fechner <<a href="mailto:mfechner@freebsd.org">mfechner@freebsd.org</a>> wrote:</div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by mfechner:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=4030b7d57c68fda7bad3230379790065dbb1ed39" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=4030b7d57c68fda7bad3230379790065dbb1ed39</a><br>; <br> commit 4030b7d57c68fda7bad3230379790065dbb1ed39<br> Author: Matthias Fechner <mfechner@FreeBSD.org><br> AuthorDate: 2025-11-30 05:50:26 +0000<br> Commit: Matthias Fechner <mfechner@FreeBSD.org><br> CommitDate: 2025-11-30 05:50:26 +0000<br> <br> devel/opentelemetry-cpp: fix build error<br> <br> Added devel/c4core as a lib dependency:<br> ====> Running Q/A tests (stage-qa)<br> Error: /usr/local/lib/libopentelemetry_configuration.so.1.24.0 is linked to /usr/local/lib/libc4core.so.0.2.6 from devel/c4core but it is not declared as a dependency<br> Warning: you need LIB_DEPENDS+=libc4core.so:devel/c4core<br> Warning: you might not need LIB_DEPENDS on libcurl.so<br> Warning: you might not need LIB_DEPENDS on libgtest.so<br> *** Error code 1<br> <br> Approved by: just-fix-it<br></blockquote><div><br></div><div>This is incorrect.</div><div><div>It is an indirect dependency brought by devel/rapidyaml.</div></div><div>Since it is not a direct dependency, it should not be added to LIB_DEPENDS.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> ---<br> devel/opentelemetry-cpp/Makefile | 4 +++-<br> 1 file changed, 3 insertions(+), 1 deletion(-)<br> <br> diff --git a/devel/opentelemetry-cpp/Makefile b/devel/opentelemetry-cpp/Makefile<br> index 65622b0ee5b9..7b5c7e99f3a1 100644<br> --- a/devel/opentelemetry-cpp/Makefile<br> +++ b/devel/opentelemetry-cpp/Makefile<br> @@ -1,6 +1,7 @@<br> PORTNAME= opentelemetry-cpp<br> PORTVERSION= 1.24.0<br> DISTVERSIONPREFIX= v<br> +PORTREVISION= 1<br> CATEGORIES= devel<br> <br> MAINTAINER= sunpoet@FreeBSD.org<br> @@ -11,7 +12,8 @@ WWW= <a href="https://opentelemetry.io/" rel="noreferrer" target="_blank">https://opentelemetry.io/</a>; \<br> LICENSE= APACHE20<br> LICENSE_FILE= ${WRKSRC}/LICENSE<br> <br> -LIB_DEPENDS= libcurl.so:ftp/curl \<br> +LIB_DEPENDS= libc4core.so:devel/c4core \<br> + libcurl.so:ftp/curl \<br> libgtest.so:devel/googletest \<br> libryml.so:devel/rapidyaml<br> TEST_DEPENDS= benchmark>=0:devel/benchmark<br> <br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q1MWCCfgogRatQsq=RGwP2sAPyezom%2BHq3kU_XwU0SeA>