Date: Tue, 19 Jan 2016 18:38:54 -0800 From: Adrian Chadd <adrian.chadd@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Marius Strobl <marius@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r294362 - in head/sys: dev/uart kern sys Message-ID: <CAJ-Vmo=ShcZX3NsVghOk0XHSpRgfiL8tXD-2d2zYeyN7W-E_bQ@mail.gmail.com> In-Reply-To: <1839427.BLR7n8zvy2@ralph.baldwin.cx> References: <201601192334.u0JNYST5080954@repo.freebsd.org> <2881455.20ba4MY9ds@ralph.baldwin.cx> <1839427.BLR7n8zvy2@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 January 2016 at 18:36, John Baldwin <jhb@freebsd.org> wrote: [snip] > > The code in ttydev_leave() is: > > /* Drain any output. */ > MPASS((tp->t_flags & TF_STOPPED) == 0); > if (!tty_gone(tp)) > tty_drain(tp, 1); > > Nothing in tty_drain() sets TF_GONE yet, so this seems to be a guaranteed > panic. > > Various other places also call tty_drain() when then tty is not "gone" > including the ioctl's backing tcsetattr(). ok, so should we back the patch out until it's addressed? -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=ShcZX3NsVghOk0XHSpRgfiL8tXD-2d2zYeyN7W-E_bQ>