Date: Sun, 3 Mar 2024 12:01:41 +0300
From: Gleb Popov <arrowd@freebsd.org>
To: Mathieu Arnold <mat@freebsd.org>
Cc: Thomas Zander <riggs@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG
Message-ID: <CALH631mJShhLMkULtyBSyc1H%2BH4fZBfrt=adxTGe1WxVYcPXQw@mail.gmail.com>
In-Reply-To: <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk>
References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <CALH631k%2BK%2Bf2Tpmk9HGX%2BWydcB8xe-xquRSKYitUzXGc7eO4bQ@mail.gmail.com> <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 3, 2024 at 11:56=E2=80=AFAM Mathieu Arnold <mat@freebsd.org> wr= ote: > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > knob, and not via an option. > If there is an option that enable some sort of debugging or verbose > thing but that is not supposed to add debugging symbols, then it should > not be called DEBUG. In that case we need a qa check that prevents adding DEBUG option and then we can also introduce a generic DEBUG_VAR helper to get rid of ifdefs?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631mJShhLMkULtyBSyc1H%2BH4fZBfrt=adxTGe1WxVYcPXQw>