Date: Wed, 30 Aug 2006 21:29:14 GMT From: Todd Miller <millert@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 105370 for review Message-ID: <200608302129.k7ULTEqD038168@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=105370 Change 105370 by millert@millert_g4tower on 2006/08/30 21:28:38 Fix port label memory leak introduced by @4676. Now that the port label is initialized in ipc_object_alloc() we don't need to do it (again) in ipc_port_init(). We *do*, however, need to init the port label in ipc_port_alloc_special(), since that doesn't go through the normal ipc_object_alloc() code path (kernel ports are special). Affected files ... .. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_port.c#3 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_port.c#3 (text+ko) ==== @@ -471,10 +471,6 @@ #endif /* MACH_ASSERT */ ipc_mqueue_init(&port->ip_messages, FALSE /* set */); - -#ifdef MAC - mac_port_init_label (&port->ip_label); -#endif } /* @@ -1153,7 +1149,7 @@ * we will use a new entry point for this purpose, as current_task() * is often wrong (i.e. not kernel_task) or null. */ - + mac_port_init_label(&port->ip_label); mac_port_create_kernel(&port->ip_label, space == ipc_space_reply); #endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608302129.k7ULTEqD038168>