Date: Sat, 8 May 2004 21:30:28 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: arch@freebsd.org Subject: Re: New ACPI blacklist format Message-ID: <20040508193028.GH24376@darkness.comp.waw.pl> In-Reply-To: <20040508113421.R58706@root.org> References: <20040507231846.F52653@root.org> <20040508.054429.99235478.imp@bsdimp.com> <20040508113421.R58706@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--aUiDxsG/XgXmoT1Q
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, May 08, 2004 at 11:37:26AM -0700, Nate Lawson wrote:
+> > : struct acpi_table_desc {
+> > : char *signature;
+> > : char *oem_id;
+> > : char *oem_table_id;
+> > : char *oem_rev_op;
+> > : char *oem_revision;
+> > : char *creator_id;
+> > : char *creator_rev_op;
+> > : char *creator_revision;
+> > : };
+> > :
+> > : struct acpi_blacklist {
+> > : int quirk;
+> > : struct acpi_table_desc *match;
+> > : };
+> > :
+> > : #define ACPI_BROKEN 0x1
+> > :
+> > : static struct acpi_table_desc Abit_BP6[] =3D {
+> > : { "FACP", "AWARD", "AWRDACPI", "<=3D", "30302e31", "", "", "" },
+> > : };
[...]
+> [...] What I meant by compacting was to get a variable
+> number of acpi_table_desc elements in a single blacklist entry without
+> defining a separate static. Something like this:
+>=20
+> static struct acpi_blacklist blacklist[] =3D {
+> {
+> .quirk =3D ACPI_BROKEN,
+> {
+> { "FACP", ... },
+> { "DSDT", ... }
+> }
+> },
+> {
+> .quirk =3D ...
+> }
+> };
+>=20
+> The compiler didn't allow this.
Because you have to do something like this:
struct acpi_blacklist {
int quirk;
struct acpi_table_desc match[DEFINED_SIZE];
};
--=20
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
--aUiDxsG/XgXmoT1Q
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAnTVUForvXbEpPzQRAoW9AJ9hWdkTTe+soNgPkdyVK/gbe9+ZewCgmWL5
NhfFNRrpUdQUKc8BirDpYlM=
=IdJH
-----END PGP SIGNATURE-----
--aUiDxsG/XgXmoT1Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040508193028.GH24376>