Date: Wed, 20 Dec 2006 04:06:23 +0100 (CET) From: Martin Blapp <mb@imp.ch> To: Attilio Rao <attilio@freebsd.org> Cc: cvs-src@freebsd.org, Martin Blapp <mbr@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <20061220040337.H53548@godot.imp.ch> In-Reply-To: <3bbf2fe10612191850y3a546fcew486575385b1400df@mail.gmail.com> References: <200612192234.kBJMYYo0055529@repoman.freebsd.org> <3bbf2fe10612191850y3a546fcew486575385b1400df@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, > Since proctree_lock is a sx lock which uses 2 condition variables, > they alredy drop Giant (DROP_GIANT()) before sleeping. Are you secure > it is the right thing to do here? Sorry, the commit message was not 100% clear. It should have been: Retest a variable after sx_slock has been called. Giant might have been temporarily dropped while waiting for proctree_lock, allowing for an intervening tty_close() that cleared tp->t_session. Martin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061220040337.H53548>