Date: Fri, 19 Oct 2018 14:21:02 -0400 From: Ed Maste <emaste@freebsd.org> To: gerald@pfeifer.com Cc: Antoine Brodin <antoine@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339350 - head/contrib/elftoolchain/elfcopy Message-ID: <CAPyFy2CVv_8KJ4rsgDTXfhrNWYm32CCtG5q%2BfrZBdzO16Rmj%2BQ@mail.gmail.com> In-Reply-To: <alpine.LSU.2.21.1810191551310.3749@anthias.pfeifer.com> References: <201810132126.w9DLQ73C022496@repo.freebsd.org> <CAALwa8k5k7T2Xy6jSq0bbj%2Biq0T_FwctOZ-=ZLkCU6eS1%2BCoKg@mail.gmail.com> <CAPyFy2Cv2ydYWmBvWxoM9ACw2iCnq7xfsngEyOPF7XNK7P8ckA@mail.gmail.com> <CAPyFy2B-Oc8rVk_iBd8z6ecK_htEF41CCEZ_9=29zMGwap5aKg@mail.gmail.com> <CAALwa8=rUZh=VaQL0Ln6TsrfaK7maAhdG88AD1ZyDc-UpDMxSQ@mail.gmail.com> <CAPyFy2BLHKQ5Tj0LD=4W367t9am0S_XKjEBhPGAz3w8fXbqw3g@mail.gmail.com> <alpine.LSU.2.21.1810191551310.3749@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 19 Oct 2018 at 09:54, Gerald Pfeifer <gerald@pfeifer.com> wrote: > > On Thu, 18 Oct 2018, Ed Maste wrote: > > I think this is probably the right approach, although I also have an > > ELF Tool Chain fix in D17596 which is waiting on the code freeze to > > end. > > I'm a little confused: This was broken most recently (as the mail > bomb that my inbox received from the pkg cluster and others indicates), > so at this point in the release cycle shouldn't > (a) the change causing all this be reverted, *or* Unfortunately there are subsequent changes that depend on the original fix which would also have to be unwound, it's not as easy as just reverting this one. > (b) a follow-up patch committed immediately, > whatever looks less risky? The follow-up patch is ready but is waiting on re@. At this point I expect I can commit in two days and then will need to re-request to merge to stable/12.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CVv_8KJ4rsgDTXfhrNWYm32CCtG5q%2BfrZBdzO16Rmj%2BQ>