Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jan 2002 16:01:43 -0800
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        Jim Binkley <jrb@cs.pdx.edu>
Cc:        freebsd-mobile@FreeBSD.ORG
Subject:   Re: wi0: if_wi.c access point scanning
Message-ID:  <20020128160143.A14088@Odin.AC.HMC.Edu>
In-Reply-To: <200201172216.OAA08863@sirius.cs.pdx.edu>; from jrb@cs.pdx.edu on Thu, Jan 17, 2002 at 02:16:01PM -0800
References:  <200201172216.OAA08863@sirius.cs.pdx.edu>

next in thread | previous in thread | raw e-mail | index | archive | help

--G4iJoqBmSsgzjUCe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

I tried the code late last week and I'm not having any luck with it.  I
run wicontrol and get the scanning printout and a bunch of dots, but it
just fails with EINVAL when the timeout passes.  I'm using a Lucent
card.  Any ideas?

A couple comments on the patch.  First, I really don't like the way
the code returns EINVAL when it's busy.  I think I'd prefer EBUSY or
EAGAIN though I'm not sure which is correct.  Second, the patch isn't
very style(9) compliant.  Admitidly, the existing code in the driver
isn't very compliant either, but I'd prefer to avoid making it worse.
Most of the issues are with multi-line comments or with the formatting
of control structures.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--G4iJoqBmSsgzjUCe
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8VeZnXY6L6fI4GtQRAq+jAKC3PSZnVSBhSmCrYh6m+yvcITaApgCgkAeU
yshnsgdUmhmvGUPei+NxoQs=
=Vzb9
-----END PGP SIGNATURE-----

--G4iJoqBmSsgzjUCe--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020128160143.A14088>