Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Mar 2021 06:51:17 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 253915] pchtherm0: Sensor enable failed
Message-ID:  <bug-253915-227-mttA5otyxC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-253915-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-253915-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253915

--- Comment #1 from michal@microwave.sk ---
I managed to fix this first issue with this simple patch:

# git diff
diff --git a/sys/dev/intel/pchtherm.c b/sys/dev/intel/pchtherm.c
index 13f0abc54b6..4a9edc2da28 100644
--- a/sys/dev/intel/pchtherm.c
+++ b/sys/dev/intel/pchtherm.c
@@ -163,7 +163,7 @@ static int pchtherm_attach(device_t dev)
                        bus_write_1(sc->tbar, PCHTHERM_REG_TSEL,
                                    PCHTHERM_GEN_ENABLE);
                        sc->enable =3D bus_read_1(sc->tbar, PCHTHERM_REG_TS=
EL);
-                       if (!(sc->enable & PCHTHERM_REG_TSEL)){
+                       if (!(sc->enable & PCHTHERM_GEN_ENABLE)) {
                                device_printf(dev, "Sensor enable failed\n"=
);
                                return 0;
                        }

Now pchtherm gets enabled as it should:

# dmesg | grep pchtherm
pchtherm0: <Haswell Thermal Subsystem> mem 0x383ffff10000-0x383ffff10fff ir=
q 18
at device 31.6 on pci1
pchtherm0: Enabling Sensor

But reported values are strange:

# sysctl dev.pchtherm
dev.pchtherm.0.ctt: 130.0C
dev.pchtherm.0.talv: -50.0C
dev.pchtherm.0.tahv: -50.0C
dev.pchtherm.0.temperature: 67.5C
dev.pchtherm.0.pch_hot_level: -50.0C
dev.pchtherm.0.t2temp: -50.0C
dev.pchtherm.0.t1temp: -50.0C
dev.pchtherm.0.t0temp: -50.0C
dev.pchtherm.0.pmtime: 1
dev.pchtherm.0.pmtemp: -50.0C
dev.pchtherm.0.%parent: pci1
dev.pchtherm.0.%pnpinfo: vendor=3D0x8086 device=3D0x8c24 subvendor=3D0x15d9
subdevice=3D0x086d class=3D0x118000
dev.pchtherm.0.%location: slot=3D31 function=3D6 dbsf=3Dpci0:0:31:6
handle=3D\_SB_.PCI0.TERM
dev.pchtherm.0.%driver: pchtherm
dev.pchtherm.0.%desc: Haswell Thermal Subsystem
dev.pchtherm.%parent:=20

regards,
michal

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253915-227-mttA5otyxC>