Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Sep 2012 14:21:10 -0400
From:      George Neville-Neil <gnn@neville-neil.com>
To:        John-Mark Gurney <jmg@funkthat.com>
Cc:        freebsd-arm@FreeBSD.org
Subject:   Re: minor patches to cpsw and arm conf files
Message-ID:  <D5CD6F3C-BD08-4FFC-92B2-D5D780927950@neville-neil.com>
In-Reply-To: <20120914180318.GX58312@funkthat.com>

index | next in thread | previous in thread | raw e-mail


On Sep 14, 2012, at 14:03 , John-Mark Gurney <jmg@funkthat.com> wrote:

> The first patch removes some dead code, an incorrect comment, and some
> anoying printf's from TI's cpsw driver.  I left the other printf's in
> the same function since they are clearly there to denote unimplemented
> functionality.
> 
> The second patch fixes up the conf files such that they follow the
> proper format of options<space><tab>...  This applied for both
> commented out options and uncommented options...  I also fixes a few
> that had "#<space>options" and the like to make it more standard...
> 
> for people who care, part of it was automated with:
> for i in `grep -l '^#options<tab>' *'; do sed -e 's/^#options<tab>/options /' < $i > tmp && mv tmp $i; done
> for i in `grep -l '^options<tab>' *'; do sed -e 's/^options<tab>/options /' < $i > tmp && mv tmp $i; done
> 
> Anyone have any objections to me committing these?
> 

This all looks fine to me.  Thanks!

Best,
George




help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D5CD6F3C-BD08-4FFC-92B2-D5D780927950>