Date: Sat, 23 Jun 2012 10:23:04 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: FreeBSD Ports <ports@FreeBSD.org>, Olli Hauer <ohauer@FreeBSD.org>, Ganael LAPLANCHE <martymac@FreeBSD.org>, Doug Barton <dougb@FreeBSD.org>, Michael Scheidell <scheidell@FreeBSD.org> Subject: Re: optionsng and tinderbox? Message-ID: <4FE58AF8.9060203@FreeBSD.org> In-Reply-To: <20120623081843.GC41054@ithaqua.etoilebsd.net> References: <4FE12F2D.9080302@FreeBSD.org> <20120620061136.GA79164@ithaqua.etoilebsd.net> <4FE1829D.6030109@FreeBSD.org> <20120620091321.GA83730@ithaqua.etoilebsd.net> <20120620094431.M12775@martymac.org> <20120620103412.GB83730@ithaqua.etoilebsd.net> <4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org> <4FE4AEFC.4070405@FreeBSD.org> <4FE51858.4010502@FreeBSD.org> <20120623081843.GC41054@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig4C237409554FE9907D5C1889
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 23/06/2012 09:18, Baptiste Daroussin wrote:
> Well the priority ordering the logical was to give the end word to the =
last user
> action.
>=20
> It goes from global to specific
>=20
> 1/ the global options (infrastructures) are applied
> 2/ the maintainer option (ports are applied)
> 3/ the user global options are applied (OPTIONS_{,UN}SET)
> 4/ the user ports options are applied (${UNIQUENAME}_{,UN}SET)
> 5/ the dialog (make config) options are applied
>=20
> If that it looks not good to anyone, please comment (we can still chang=
e it) and
> please provide arguments.
It's the ordering of 4 and 5 that confuses me.
If you've got ${UNIQUENAME}_{,UN}SET in /etc/make.conf and then you run
'make config' you'ld expect the choices you make in the dialogue to be
the final word. (ie. 5 overrides 4, as currently) (Would you expect the
make.conf setting to affect what is shown in the dialog initially?
Seems logical)
On the other hand, if you run 'make foo_SET=3Dyes all' on a command line,=
you'ld expect the command line to override anything saved in an options
file (ie 4 overrides 5).
I don't think you can have both of those behaviours in any reasonable
way. If forced to choose, I'd prefer to have the capability to override
a config setting as a one-off on the command line.
Also given that in normal usage, selections would always be made in the
options dialogue when the port was compiled, so they would always
override any ${UNIQUENAME}_{,UN}SET setting in /etc/make.conf or from
the command line. Which implies ${UNIQUENAME}_{,UN}SET only has any
utility when the options dialogues are not used, such as in tinderbox or
other port building systems. Swapping 4 and 5 would make the behaviour
more consistent for all usage patterns.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey
--------------enig4C237409554FE9907D5C1889
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk/liv8ACgkQ8Mjk52CukIw7AgCfXg1KWULgm8T4K8hEYoQkKj6f
xlkAoI0qzS40X3E+/wbKkN2BBg1OH295
=eQcu
-----END PGP SIGNATURE-----
--------------enig4C237409554FE9907D5C1889--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FE58AF8.9060203>