Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 02 Oct 2019 10:44:12 -0700
From:      Ravi Pokala <rpokala@freebsd.org>
To:        Roger Pau =?UTF-8?B?TW9ubsOp?= <royger@FreeBSD.org>, Ravi Pokala <rpokala@freebsd.org>
Cc:        <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r352925 - head/sys/dev/xen/control
Message-ID:  <C2BEB9AD-204A-41E1-B748-759BAF4822AC@panasas.com>
In-Reply-To: <20191002075302.caak27hnk5vlpqgr@Air-de-Roger>
References:  <201910010821.x918LfOg005983@repo.freebsd.org> <5E0C7E54-2657-4E70-8A18-84C4EE29D4FA@panasas.com> <20191002075302.caak27hnk5vlpqgr@Air-de-Roger>
next in thread | previous in thread | raw e-mail | index | archive | help 


-----Original Message-----
From: Roger Pau Monné <royger@FreeBSD.org>
Date: 2019-10-02, Wednesday at 00:53
To: Ravi Pokala <rpokala@freebsd.org>
Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: Re: svn commit: r352925 - head/sys/dev/xen/control

    On Tue, Oct 01, 2019 at 06:42:14PM -0700, Ravi Pokala wrote:
    > Hi Roger,
    > 
    > If I'm understanding this diff correctly, all of (poweroff, reboot, suspend) will use the common string "shutdown", rather than an event-specific string. Is that what we want?
    
    I think there's some misunderstanding here. All power control events
    use the same xenstore node (~/control/shutdown), but the command read
    from it is different depending on the requested action (poweroff,
    reboot, halt...).

Ah! Yes indeed, that was a misunderstanding on my part. I thought "shutdown" was the command text, rather than a component of the path containing the command.

    See [0] for a slightly more detailed description of the xenstore node.
    
    Note that this commit doesn't change any of this logic, it just clears
    the contents of ~/control/shutdown (by writing "") so the toolstack
    knows FreeBSD has acknowledged the request and it's processing it.

Yes, that all makes sense.

Thanks for clarifying!

-Ravi (rpokala@)

    Roger.
    
    [0] http://xenbits.xen.org/docs/4.12-testing/misc/xenstore-paths.html#platform-feature-and-control-paths

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C2BEB9AD-204A-41E1-B748-759BAF4822AC>