Date: Wed, 5 Feb 2025 19:37:19 GMT From: Michael Tuexen <tuexen@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: ac863fd8298c - stable/13 - TCP BBR: remove assignments without effect Message-ID: <202502051937.515JbJGI049755@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=ac863fd8298cc1d58a88c0a668845b2c87c140b8 commit ac863fd8298cc1d58a88c0a668845b2c87c140b8 Author: Michael Tuexen <tuexen@FreeBSD.org> AuthorDate: 2024-12-30 14:57:11 +0000 Commit: Michael Tuexen <tuexen@FreeBSD.org> CommitDate: 2025-02-05 19:22:20 +0000 TCP BBR: remove assignments without effect No functional change intended. Reviewed by: rrs CID: 1523772 CID: 1523777 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48215 (cherry picked from commit 895347fc10c5b06bddadcc2937fdcf298c7e1114) --- sys/netinet/tcp_stacks/bbr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index 5ebf82eb97d9..7faeadabf203 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -7358,11 +7358,9 @@ bbr_log_ack(struct tcpcb *tp, struct tcpopt *to, struct tcphdr *th, p_maxseg = min(bbr->r_ctl.rc_pace_max_segs, maxseg); th_ack = th->th_ack; if (SEQ_GT(th_ack, tp->snd_una)) { - acked = th_ack - tp->snd_una; bbr_log_progress_event(bbr, tp, ticks, PROGRESS_UPDATE, __LINE__); bbr->rc_tp->t_acktime = ticks; - } else - acked = 0; + } if (SEQ_LEQ(th_ack, tp->snd_una)) { /* Only sent here for sack processing */ goto proc_sack;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502051937.515JbJGI049755>