Date: Sat, 26 May 2001 18:28:24 -0700 (PDT) From: sean@mcneil.com To: freebsd-gnats-submit@FreeBSD.org Subject: kern/27674: IDE Interrupts disabled on resume Message-ID: <200105270128.f4R1SOE28134@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 27674
>Category: kern
>Synopsis: IDE Interrupts disabled on resume
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat May 26 18:30:03 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: Sean McNeil
>Release: 5.0-CURRENT
>Organization:
Sean McNeil Consulting
>Environment:
FreeBSD mobile.mcneil.com 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Wed May 23 20:45:46 PDT 2001 root@mobile.mcneil.com:/usr/src/sys/compile/INSPIRON i386
>Description:
With INSPIRON 3500, the IDE device will cause a system hang because of interrupts in an incorrect state.
>How-To-Repeat:
Suspend INSPIRON and then Resume.
>Fix:
The following patch prevents system lockup upon resume. I do not know of any side effects from this patch but there could be a performance degradation.
*** /sys/dev/ata/ata-all.c Thu May 17 03:29:30 2001
--- ./ata-all.c Sat May 26 18:15:36 2001
*************** out:
*** 946,952 ****
--- 946,954 ----
#endif
/* disable interrupt from device */
+ #if 0
if (scp->flags & ATA_QUEUED)
+ #endif
ATA_OUTB(scp->r_altio, ATA_ALTSTAT, ATA_A_IDS | ATA_A_4BIT);
/* select device */
*************** out:
*** 974,980 ****
--- 976,984 ----
ATA_OUTB(scp->r_io, ATA_CMD, command);
/* enable interrupt */
+ #if 0
if (scp->flags & ATA_QUEUED)
+ #endif
ATA_OUTB(scp->r_altio, ATA_ALTSTAT, ATA_A_4BIT);
if (await(PRIBIO, 10 * hz)) {
*************** out:
*** 1005,1011 ****
--- 1009,1017 ----
active2str(flags));
}
/* enable interrupt */
+ #if 0
if (scp->flags & ATA_QUEUED)
+ #endif
ATA_OUTB(scp->r_altio, ATA_ALTSTAT, ATA_A_4BIT);
return error;
}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105270128.f4R1SOE28134>