Date: Wed, 20 Dec 2006 03:50:21 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Martin Blapp" <mbr@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <3bbf2fe10612191850y3a546fcew486575385b1400df@mail.gmail.com> In-Reply-To: <200612192234.kBJMYYo0055529@repoman.freebsd.org> References: <200612192234.kBJMYYo0055529@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2006/12/19, Martin Blapp <mbr@freebsd.org>: > mbr 2006-12-19 22:34:33 UTC > > FreeBSD src repository > > Modified files: > sys/kern tty.c > Log: > Giant might have been temporarily dropped while waiting for proctree_lock, allowing for an > intervening tty_close() that cleared tp->t_session. Since proctree_lock is a sx lock which uses 2 condition variables, they alredy drop Giant (DROP_GIANT()) before sleeping. Are you secure it is the right thing to do here? Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10612191850y3a546fcew486575385b1400df>