Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Apr 2017 15:16:42 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316851 - head/sys/x86/iommu
Message-ID:  <201704141516.v3EFGgK9087765@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Fri Apr 14 15:16:41 2017
New Revision: 316851
URL: https://svnweb.freebsd.org/changeset/base/316851

Log:
  Correct calculation of the entry->free_down in the invariants-checking
  code.
  
  Reported by:	maxim
  Found by:	PVS studio scan
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/x86/iommu/intel_gas.c

Modified: head/sys/x86/iommu/intel_gas.c
==============================================================================
--- head/sys/x86/iommu/intel_gas.c	Fri Apr 14 15:09:30 2017	(r316850)
+++ head/sys/x86/iommu/intel_gas.c	Fri Apr 14 15:16:41 2017	(r316851)
@@ -198,7 +198,7 @@ dmar_gas_check_free(struct dmar_domain *
 			    l->free_down));
 		} else {
 			v = MAX(entry->free_after, l->free_down);
-			v = MAX(entry->free_down, r->free_down);
+			v = MAX(v, r->free_down);
 			MPASS(entry->free_down == v);
 		}
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704141516.v3EFGgK9087765>