Date: Thu, 25 Sep 2003 16:35:47 +0100 From: Ceri Davies <setantae@submonkey.net> To: Josef El-Rayes <j.el-rayes@daemon.li> Cc: Ken Smith <kensmith@FreeBSD.org> Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml Message-ID: <20030925153547.GB88033@submonkey.net> In-Reply-To: <20030925152525.GA410@daemon.li> References: <200309251252.h8PCq7Tc093693@repoman.freebsd.org> <20030925152525.GA410@daemon.li>
next in thread | previous in thread | raw e-mail | index | archive | help
--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Sep 25, 2003 at 05:25:25PM +0200, Josef El-Rayes wrote:
> Ken Smith <kensmith@FreeBSD.org> wrote:
> > - "whitespace change" that coverts existing driver example code
> > to be style(9) compliant, matching format of new driver code
>=20
> for me this is strange, i always thought that we do not do patches which
> do whitespace changes only - which does make the repository bigger
> without any real benefit.
> =
=20
> is there a special reason why we do this here?
We always make whitespace only changes separately, so that translators know
they can ignore the whitespace commits.
Gratuitous whitespace sweeps are contentious, but not nearly as much as many
small whitespace changes. The difference with Ken's commit is that if a
commit you have made has made a section look ugly, then you should immediat=
ely
follow it up with a whitespace commit to reindent it.
Ceri
--=20
User: DO YOU ACCEPT JESUS CHRIST AS YOUR PERSONAL LORD AND SAVIOR?
Iniaes: Sure, I can accept all forms of payment.
-- www.chatterboxchallenge.com
--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQE/cwtTocfcwTS3JF8RAi6dAJ0SGUKbz0iv/9JFk8DKdbC+seuzGwCeI7S5
9Kwk5VtQ189noa0f5dIvVJA=
=c9e5
-----END PGP SIGNATURE-----
--pWyiEgJYm5f9v55/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030925153547.GB88033>