Date: Thu, 07 Oct 2004 13:58:13 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: marcel@xcllnt.net Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys pbioio.h src/sys/i386/isa pbio.c src/sys/conf files.i386 src/sys/i386/conf NOTES Message-ID: <20041007.135813.110909154.imp@bsdimp.com> In-Reply-To: <20041007190453.GA82804@ns1.xcllnt.net> References: <20041007175206.GA82275@ns1.xcllnt.net> <20041007.122005.127628260.imp@bsdimp.com> <20041007190453.GA82804@ns1.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20041007190453.GA82804@ns1.xcllnt.net>
Marcel Moolenaar <marcel@xcllnt.net> writes:
: On Thu, Oct 07, 2004 at 12:20:05PM -0600, M. Warner Losh wrote:
: > In message: <20041007175206.GA82275@ns1.xcllnt.net>
: > Marcel Moolenaar <marcel@xcllnt.net> writes:
: > : On Thu, Oct 07, 2004 at 04:21:03PM +0000, Warner Losh wrote:
: > : > imp 2004-10-07 16:21:03 UTC
: > : >
: > : > FreeBSD src repository
: > : >
: > : > Modified files:
: > : > sys/conf files.i386
: > : > sys/i386/conf NOTES
: > : > Added files:
: > : > sys/sys pbioio.h
: > : > sys/i386/isa pbio.c
: > : > Log:
: > : > Port pbio to HEAD.
: > :
: > : I appreciate your speed, but don't you think that pbioio.h is pretty
: > : MD given that the driver only exists on i386. Wouldn't <machine/pbioio.h>
: > : be a better place?
: >
: > I think that pbioio.h is MI. What makes you think that it is pretty
: > MD?
:
: Because pbio(4) only exists on i386. Hence, all other platforms now
: have <sys/pbioio.h> that serves no purpose and can only cause
: autoconfiguration (ala autoconf) getting confused. Since pbioio.h
: refers to hardware, it nature is MD, even though the definitions
: (types and interfaces) may appear MI. So, <machine/bpioio.h> seems
: like a good place.
But we've had lots of problems in the past where MD drivers became MI
drivers with 10 identical copies of machine/fooio.h. The driver
likely copy become MI relatively easily.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041007.135813.110909154.imp>