Date: Wed, 18 Aug 2004 11:20:58 -0700 From: Julian Elischer <julian@elischer.org> To: John Polstra <jdp@polstra.com> Cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Subject: Re: netgraph only on i386/ia64 - why ? Message-ID: <41239E0A.30508@elischer.org> In-Reply-To: <XFMail.20040817094857.jdp@polstra.com> References: <XFMail.20040817094857.jdp@polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John Polstra wrote: > On 17-Aug-2004 Harti Brandt wrote: > >>On Mon, 16 Aug 2004, Bjoern A. Zeeb wrote: >> >>BAZ>Hi, >>BAZ> >>BAZ>It seems netgraph is only build on ia64 and i386. >>BAZ>Can someone please explain why ? >> >>Until around april I used all the ATM related Ng stuff regularily (this >>include ng_socket, all the stuff under netgraph/atm). I think this should >>just be enabled. Unless build problems have been introduced since then, >>it should just be enabled. > > > There is one problem with netgraph on 64-bit platforms. The ng_msghdr > struct is 52 bytes / 4-byte aligned (see ng_message.h). That means > the message payload is not well-aligned for 64-bit platforms. It > would be nice to fix that (and bump NG_VERSION, of course). Nobody > ever guaranteed that the message payload would be aligned, but it > makes things a lot more convenient. if we do this we should do it now so that we have a consistent ABI from 5.3 on.. scott (et al), should we pad an extra 4 bytes in this now? it's low/no risk, but better now than after 5.3 has been released.. > > John > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41239E0A.30508>