Date: Thu, 19 Jul 2001 10:40:36 -0400 (EDT) From: Mikhail Teterin <mi@aldan.algebra.com> To: kris@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/mailwrapper mailwrapper.c Message-ID: <200107191440.f6JEedO32662@aldan.algebra.com> In-Reply-To: <200107190504.f6J54ka10016@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 Jul, Kris Kennaway wrote:
> kris 2001/07/18 22:04:46 PDT
>
> Modified files: (Branch: RELENG_4)
> usr.sbin/mailwrapper mailwrapper.c
> Log:
> MFC: r1.6: You can't free a string and then use it as the error
> message to errx. Instead use warn to print the string, then cleanup
> and exit normally.
This is not the first place to have this issue (I remember a similar
commit from the past). May be, it is time to add another err* function,
which will free the passed error message prior to exiting?
It was not there before, I guess, because the "founding fathers" did not
concern themselves with the fate of the allocated memory after exit :-)
--
|\__-----__/|
_____/ ::::: :::\_____
'__--( ::::::::..::)--__` -mi
If you have a / _- \/ :::::::\/ -_
serious knowledge / / :. .::::\ \
about computers -- | ::::::::::::| Ok, let's say you broke
keep it in a secret! _|/ ::::____::\|_ the wall with your head
"Rules of dating", / /:::::/:_::\::\:.\ What are you going to
'Playboy', ? 1994 | :| ..:(_/ \::|::|::| do in the next cell?
| :|:::::. ::|: |::|.:| Stanislaw J. Lec
\ |:: :::_/::/: :|:/
((___\____\____/___/___))
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107191440.f6JEedO32662>