Date: Fri, 14 Nov 2014 10:17:35 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274517 - projects/sendfile/sys/vm Message-ID: <F29804BE-DBDD-45D7-AC71-D1B9482C4415@gmail.com> In-Reply-To: <201411141801.sAEI1IWo066725@svn.freebsd.org> References: <201411141801.sAEI1IWo066725@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Nov 14, 2014, at 10:01, Gleb Smirnoff <glebius@freebsd.org> wrote: > Author: glebius > Date: Fri Nov 14 18:01:18 2014 > New Revision: 274517 > URL: https://svnweb.freebsd.org/changeset/base/274517 >=20 > Log: > Use C99 "inline" keyword. >=20 > Modified: > projects/sendfile/sys/vm/vm_pager.h >=20 > Modified: projects/sendfile/sys/vm/vm_pager.h > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- projects/sendfile/sys/vm/vm_pager.h Fri Nov 14 18:00:00 2014 = (r274516) > +++ projects/sendfile/sys/vm/vm_pager.h Fri Nov 14 18:01:18 2014 = (r274517) > @@ -106,7 +106,7 @@ vm_object_t vm_pager_allocate(objtype_t, > void vm_pager_bufferinit(void); > void vm_pager_deallocate(vm_object_t); > static __inline int vm_pager_get_pages(vm_object_t, vm_page_t *, int, = int); > -static __inline int vm_pager_get_pages_async(vm_object_t, vm_page_t = *, int, > +static inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, = int, > int, void(*)(void *, int), void *); > static __inline boolean_t vm_pager_has_page(vm_object_t, vm_pindex_t, = int *, int *); > void vm_pager_init(void); > @@ -138,7 +138,7 @@ vm_pager_get_pages( > return (r); > } - What was wrong with using the "non-C99" constant? - Why not the other cases above that, e.g. vm_pager_get_pages? --Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUZkc/AAoJEMZr5QU6S73eKtIH+wY7E247wiLCQ4tde1EVbh0Y zn+Xr18YFpm47YxQOYSkZ1cvBAtyBtPbD+QGKJQ2rPu5r3sgGYG8sqMXF+8l89U/ ADtkZ69KrFDBcPobbe5hqGET7PcOA8/b/gJmVPJpzkthtdkjiH6F5p79VQ3xKOJp 17cHjYk18b4+OvcYT5GHZyd4xWMXhsrIahV8aJmS/Uyk6fgG4XjNWbVvqh2642P9 +mgMNW1exh3kGws8A+Edk1B+tbOyFlMR1KSUjkwRROIgtoKqnyC3YEGC7qUT/dDV SXl28F5hKw4wWTcpU6olQrRXkX42Cge43yvI6ZJ/gIHl3EgABlxMRov7rRG9Zzc= =HcJY -----END PGP SIGNATURE----- --Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F29804BE-DBDD-45D7-AC71-D1B9482C4415>