Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Nov 2012 21:22:55 +0200
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r243095 - head/sys/dev/agp
Message-ID:  <20121115192255.GH73505@kib.kiev.ua>
In-Reply-To: <201211151849.qAFInHeU039083@svn.freebsd.org>
References:  <201211151849.qAFInHeU039083@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--jb7C7uZ/dsJO9et2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 15, 2012 at 06:49:17PM +0000, Eitan Adler wrote:
> Author: eadler
> Date: Thu Nov 15 18:49:17 2012
> New Revision: 243095
> URL: http://svnweb.freebsd.org/changeset/base/243095
>=20
> Log:
>   Remove unneeded header from agp: opt_bus.h
>  =20
>   Tested with "make universe"
make universe cannot prove anything about usefulness of the removed include,
just because *_opt.h files contains only defines, which are used later
by the code like
#ifdef OPTION
do something
#endif.

If you are removing the option include, the module Makefile should be
adjusted too.

--jb7C7uZ/dsJO9et2
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlClQQ4ACgkQC3+MBN1Mb4i6owCgwUAuPEipzaSOwc1NUeHOU4fO
FswAnRUD+STV1aDBlhQcz+WiGedJCmVQ
=g3Bd
-----END PGP SIGNATURE-----

--jb7C7uZ/dsJO9et2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121115192255.GH73505>