Date: Tue, 10 Nov 2015 14:36:15 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290637 - head/lib/libc/locale Message-ID: <20151110133615.GL10134@ivaldir.etoilebsd.net> In-Reply-To: <5641EF26.8060600@freebsd.org> References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--/ZYM6PqDyfNytx60 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: > On 10.11.2015 16:04, Baptiste Daroussin wrote: > > On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: > >> On 10.11.2015 11:11, Baptiste Daroussin wrote: > >>> Author: bapt > >>> Date: Tue Nov 10 08:11:27 2015 > >>> New Revision: 290637 > >>> URL: https://svnweb.freebsd.org/changeset/base/290637 > >>> > >>> Log: > >>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales > >>> as it used to be in previous version of the locales. Returning > >>> "POSIX" has too many fallouts. > >> > >> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be > >> different with real US-ASCII. It is what glibc returns for C/POSIX > >> locale and most ports expected, being linux-oriented. > >> > > I thought about it, but in the end it is probably safer for now that nl= _langinfo > > return US-ASCII as it did in the past, to reduce breakage with FreeBSD = only code > > that maybe be existing ou there. >=20 > All FreeBSD code I know never check locale this way. IMHO probability of > potential danger to meet some linux-oriented port with this check is > much much higher than to meet similar FreeBSD only code in the wild. In > any case, changing collate order from A-Za-z to aA-zZ we do just now > have much higher probability to break unknown FreeBSD only code, so one > breaking change can go with other one together. >=20 That is true, except that the new collation thing is invalidated as soon as= you set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a workaroun= d while changing the return value of nl_langinfo() is not workaroundable. --- Bapt --/ZYM6PqDyfNytx60 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEUEARECAAYFAlZB8s8ACgkQ8kTtMUmk6EzJIgCeN7YthORHwzLKgrJ9JeXPmP4v LaUAmNjGL+a9PxwZDWnHPmNvE5vPi6I= =Jaf2 -----END PGP SIGNATURE----- --/ZYM6PqDyfNytx60--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151110133615.GL10134>