Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Oct 2008 21:46:21 +0300
From:      Jaakko Heinonen <jh@saunalahti.fi>
To:        Dag-Erling Smorgrav <des@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev/...
Message-ID:  <20081023184621.GA32081@ws64.jh.dy.fi>
In-Reply-To: <200810231553.m9NFrqQj060598@svn.freebsd.org>
References:  <200810231553.m9NFrqQj060598@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi,

On 2008-10-23, Dag-Erling Smorgrav wrote:
> Log:
>   Retire the MALLOC and FREE macros.  They are an abomination unto style(9).

This change introduces some bad formatting. Many statements would now
fit to 80 columns and don't need to be wrapped.

> -	MALLOC(softc, struct targ_softc *, sizeof(*softc), M_TARG,
> +	softc = malloc(sizeof(*softc), M_TARG,
>  	       M_WAITOK | M_ZERO);
.
> -	MALLOC(descr, struct targ_cmd_descr *, sizeof(*descr), M_TARG,
> +	descr = malloc(sizeof(*descr), M_TARG,
>  	       M_WAITOK);
.
> -	MALLOC(de, struct device_element *, sizeof(*de),
> +	de = malloc(sizeof(*de),
>  	    M_LINUX, M_WAITOK);

There are also places with unnecessary white space:

> +		cl->cl_rsc = malloc(		    sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
.
> +		cl->cl_fsc = malloc(		    sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
.
> +		cl->cl_usc = malloc(		    sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
.
> +		rsc_tmp = malloc(		       sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
> +		usc_tmp = malloc(		       sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
.
.
.

-- 
Jaakko



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081023184621.GA32081>