Date: Sun, 13 Apr 2014 02:43:42 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Davide Italiano" <davide@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <009FCFC8A87C4A7CBA3BCEEDDB2FB1DC@multiplay.co.uk> References: <201404130115.s3D1FbNX048346@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Interesting, I'd be curious to know what the panic for this looks like? ----- Original Message ----- From: "Davide Italiano" <davide@FreeBSD.org> > Author: davide > Date: Sun Apr 13 01:15:37 2014 > New Revision: 264392 > URL: http://svnweb.freebsd.org/changeset/base/264392 > > Log: > Fix a panic in zfs_rename(). > this is due to a wrong dereference of a vnode when it's not locked and > can be (potentially) recycled. 'sdvp' cannot be locked on zfs_rename() > entry point because the VFS can't be sure that this scenario is > LOR-free (it might violate the parent->child lock acquisition rule). > Dereference 'tdvp' instead, which is already locked on entry, and access > 'sdvp' fields only when it's safe, i.e. under ZFS_ENTER scope. > > While at it, remove the usage of VOP_REALVP, as long as this is a NOP > on FreeBSD.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?009FCFC8A87C4A7CBA3BCEEDDB2FB1DC>