Date: Tue, 06 Jul 2021 21:18:28 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Alexander Motin" <mavbsd@gmail.com> Cc: "Ram Kishore Vegesna" <ram@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 29e2dbd42c3e - main - ocs_fc: Add gendump and dump_to_host ioctl command support. Message-ID: <0BD4E409-AD73-45F8-80B4-99E6FAC7BFE6@FreeBSD.org> In-Reply-To: <2b8685de-e94b-9413-b4fd-43526c7903d3@gmail.com> References: <202107061548.166Fm2ol078877@gitrepo.freebsd.org> <E8497515-A116-4BE0-9FAE-07A8360A3ACE@FreeBSD.org> <2b8685de-e94b-9413-b4fd-43526c7903d3@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 Jul 2021, at 21:04, Alexander Motin wrote: > On 06.07.2021 14:55, Kristof Provost wrote: >> On 6 Jul 2021, at 17:48, Ram Kishore Vegesna wrote: >> The branch main has been updated by ram: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D29e2dbd42c3e2e10e606b341= 4f4d0c53021d4e86 >> >> commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86 >> Author: Ram Kishore Vegesna <ram@FreeBSD.org> >> AuthorDate: 2021-06-24 07:05:00 +0000 >> Commit: Ram Kishore Vegesna <ram@FreeBSD.org> >> CommitDate: 2021-07-06 15:38:11 +0000 >> >> ocs_fc: Add gendump and dump_to_host ioctl command support. >> >> Support to generate firmware dump. >> >> Approved by: mav(mentor) >> --- >> sys/dev/ocs_fc/ocs_gendump.c | 388 >> +++++++++++++++++++++++++++++++++++++++++++ >> sys/dev/ocs_fc/ocs_gendump.h | 42 +++++ >> sys/dev/ocs_fc/ocs_ioctl.c | 13 +- >> sys/dev/ocs_fc/ocs_ioctl.h | 3 + >> sys/dev/ocs_fc/ocs_mgmt.c | 152 ++--------------- >> sys/dev/ocs_fc/ocs_os.c | 3 +- >> sys/dev/ocs_fc/ocs_os.h | 3 +- >> sys/modules/ocs_fc/Makefile | 3 +- >> 8 files changed, 449 insertions(+), 158 deletions(-) >> >> I=E2=80=99m seeing this build failure (amd64, GENERIC kernel): >> >> |ld: error: undefined symbol: ocs_gen_dump >>> referenced by >> ocs_mgmt.c:485 (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:485) >>> >> ocs_mgmt.o:(ocs_mgmt_exec) ld: error: undefined symbol: = >> ocs_dump_to_host >>>>> referenced by ocs_mgmt.c:489 >> (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:489) >>> = >> ocs_mgmt.o:(ocs_mgmt_exec) >> *** [kernel.full] Error code 1 | >> >> Does that ring any bells? > > d0732fa81963 should fix it. Sorry for breakage. > That works. Thanks for the quick fix. =E2=80=94 Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0BD4E409-AD73-45F8-80B4-99E6FAC7BFE6>