Date: Fri, 14 Sep 2012 07:20:31 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Attilio Rao <attilio@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern Message-ID: <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> In-Reply-To: <201209132226.q8DMQMFC088169@svn.freebsd.org> References: <201209132226.q8DMQMFC088169@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: > Author: attilio > Date: Thu Sep 13 22:26:22 2012 > New Revision: 240475 > URL: http://svn.freebsd.org/changeset/base/240475 > > Log: > Remove all the checks on curthread != NULL with the exception of some MD > trap checks (eg. printtrap()). > > Generally this check is not needed anymore, as there is not a legitimate > case where curthread != NULL, after pcpu 0 area has been properly > initialized. I do not disagree with the patch, but I do with this statement. During the AP startup, there is indeed a window while curthread is NULL. Unfortunately, trying to panic there is worse then not panic. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBSsI4ACgkQC3+MBN1Mb4iUmACgh15COGVK51luTjxM2/H9qZa2 64EAn3hUbntpvxmym5hh85pK6/lY2j2Z =c/hB -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120914042031.GZ37286>