Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Feb 2026 19:06:59 +0000
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 485e916a67b4 - main - sys/compat/freebsd32: use freebsd32_uint64_t for struct kinfo_knote32
Message-ID:  <698a3053.347cb.5e4af63f@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=485e916a67b4e700de5f50873e1e7b64de394b16

commit 485e916a67b4e700de5f50873e1e7b64de394b16
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2026-02-05 19:29:46 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-02-09 18:57:19 +0000

    sys/compat/freebsd32: use freebsd32_uint64_t for struct kinfo_knote32
    
    Reviewed by:    brooks
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D55135
---
 sys/compat/freebsd32/freebsd32.h      |  6 +++---
 sys/compat/freebsd32/freebsd32_misc.c | 31 +++----------------------------
 2 files changed, 6 insertions(+), 31 deletions(-)

diff --git a/sys/compat/freebsd32/freebsd32.h b/sys/compat/freebsd32/freebsd32.h
index 1b8d2b7fe084..15e075174786 100644
--- a/sys/compat/freebsd32/freebsd32.h
+++ b/sys/compat/freebsd32/freebsd32.h
@@ -451,12 +451,12 @@ struct kinfo_knote32 {
 	union {
 		struct {
 			int		knt_vnode_type;
-			uint32_t	knt_vnode_fsid[2];
-			uint32_t	knt_vnode_fileid[2];
+			freebsd32_uint64_t knt_vnode_fsid;
+			freebsd32_uint64_t knt_vnode_fileid;
 			char		knt_vnode_fullpath[PATH_MAX];
 		} knt_vnode;
 		struct {
-			uint32_t	knt_pipe_ino[2];
+			freebsd32_uint64_t knt_pipe_ino;
 		} knt_pipe;
 	};
 };
diff --git a/sys/compat/freebsd32/freebsd32_misc.c b/sys/compat/freebsd32/freebsd32_misc.c
index 544842803e21..25a8558335e7 100644
--- a/sys/compat/freebsd32/freebsd32_misc.c
+++ b/sys/compat/freebsd32/freebsd32_misc.c
@@ -739,38 +739,13 @@ freebsd32_kinfo_knote_to_32(const struct kinfo_knote *kin,
 		break;
 	case KNOTE_EXTDATA_VNODE:
 		CP(*kin, *kin32, knt_vnode.knt_vnode_type);
-#if BYTE_ORDER == LITTLE_ENDIAN
-		kin32->knt_vnode.knt_vnode_fsid[0] = kin->knt_vnode.
-		    knt_vnode_fsid;
-		kin32->knt_vnode.knt_vnode_fsid[1] = kin->knt_vnode.
-		    knt_vnode_fsid >> 32;
-		kin32->knt_vnode.knt_vnode_fileid[0] = kin->knt_vnode.
-		    knt_vnode_fileid;
-		kin32->knt_vnode.knt_vnode_fileid[1] = kin->knt_vnode.
-		    knt_vnode_fileid >> 32;
-#else
-		kin32->knt_vnode.knt_vnode_fsid[1] = kin->knt_vnode.
-		    knt_vnode_fsid;
-		kin32->knt_vnode.knt_vnode_fsid[0] = kin->knt_vnode.
-		    knt_vnode_fsid >> 32;
-		kin32->knt_vnode.knt_vnode_fileid[1] = kin->knt_vnode.
-		    knt_vnode_fileid;
-		kin32->knt_vnode.knt_vnode_fileid[0] = kin->knt_vnode.
-		    knt_vnode_fileid >> 32;
-#endif
+		FU64_CP(*kin, *kin32, knt_vnode.knt_vnode_fsid);
+		FU64_CP(*kin, *kin32, knt_vnode.knt_vnode_fileid);
 		memcpy(kin32->knt_vnode.knt_vnode_fullpath,
 		    kin->knt_vnode.knt_vnode_fullpath, PATH_MAX);
 		break;
 	case KNOTE_EXTDATA_PIPE:
-#if BYTE_ORDER == LITTLE_ENDIAN
-		kin32->knt_pipe.knt_pipe_ino[0] = kin->knt_pipe.knt_pipe_ino;
-		kin32->knt_pipe.knt_pipe_ino[1] = kin->knt_pipe.
-		    knt_pipe_ino >> 32;
-#else
-		kin32->knt_pipe.knt_pipe_ino[1] = kin->knt_pipe.knt_pipe_ino;
-		kin32->knt_pipe.knt_pipe_ino[0] = kin->knt_pipe.
-		    knt_pipe_ino >> 32;
-#endif
+		FU64_CP(*kin, *kin32, knt_pipe.knt_pipe_ino);
 		break;
 	}
 }


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?698a3053.347cb.5e4af63f>