Date: Mon, 1 Feb 2021 14:18:47 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Michael Tuexen <Michael.Tuexen@macmic.franken.de>, Konstantin Belousov <kib@freebsd.org>, Randall Stewart <rrs@netflix.com>, Randall Stewart <rrs@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1a714ff20419 - main - This pulls over all the changes that are in the netflix tree that fix the ratelimit code. There were several bugs in tcp_ratelimit itself and we needed further work to support the multiple tag format coming for the joint TLS and Ratelimit dances. Message-ID: <CAGudoHG38YN4kj1H6Ay=Epw4dBbv2480eOjNvnT5jS%2B0hJUw9A@mail.gmail.com> In-Reply-To: <48fe9f24-e96b-1078-ada2-a8691ead6cf1@selasky.org> References: <202101281653.10SGrJWf002301@gitrepo.freebsd.org> <CAGudoHFh9HMQNUOKpfrj3tBnO2%2BhUyhnnLFVF5c1NnPD=31OFA@mail.gmail.com> <CAGudoHH=Eu7zRLWezj9mOtXH827A4k4rFsVhRn45aK589mDWvQ@mail.gmail.com> <E0ABCA13-DDCC-45E7-A12A-AB1805782152@macmic.franken.de> <CAGudoHEVy3Uif3cjLjnTz_4EzvZV0g%2Bqev1aN-MOdD1cfUKXZQ@mail.gmail.com> <48fe9f24-e96b-1078-ada2-a8691ead6cf1@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I cannot test the patch right now, but tinderbox builds for me with the offending commit reverted. On 2/1/21, Hans Petter Selasky <hps@selasky.org> wrote: > Hi, > > The attached patch should fix it. (Waiting for a quick review). But > there are more issues: > > For i386 I now see: > >> ld: error: undefined symbol: xdr_export_sec_context_res >>>>> referenced by gss_impl.c >>>>> gss_impl.o:(kgss_transfer_context) >> >> ld: error: undefined symbol: gssd_import_name_1 >>>>> referenced by gss_import_name.c >>>>> gss_import_name.o:(gss_import_name) >> >> ld: error: undefined symbol: gssd_pname_to_uid_1 >>>>> referenced by gss_pname_to_uid.c >>>>> gss_pname_to_uid.o:(gss_pname_to_uid) >>>>> referenced by gss_pname_to_uid.c >>>>> gss_pname_to_uid.o:(gss_pname_to_unix_cred) >> >> ld: error: undefined symbol: xdr_pname_to_uid_res >>>>> referenced by gss_pname_to_uid.c >>>>> gss_pname_to_uid.o:(gss_pname_to_unix_cred) >> >> ld: error: undefined symbol: gssd_release_cred_1 >>>>> referenced by gss_release_cred.c >>>>> gss_release_cred.o:(gss_release_cred) >> >> ld: error: undefined symbol: gssd_release_name_1 >>>>> referenced by gss_release_name.c >>>>> gss_release_name.o:(gss_release_name) >> > > Maybe xdr needs to be added to LINT now? > > Passing the ball onto Konstantin. > > --HPS > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHG38YN4kj1H6Ay=Epw4dBbv2480eOjNvnT5jS%2B0hJUw9A>